mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFCv3 10/21] tcm: Add SPC-4 compliant Persistent Reservations (PR)
Date: Mon, 08 Nov 2010 13:27:13 -0800	[thread overview]
Message-ID: <1289251633.27226.66.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <20101108145054.GA1295@infradead.org>

On Mon, 2010-11-08 at 09:50 -0500, Christoph Hellwig wrote:
> Gcc on 32-bit x86 doesn't seem too happy about the stack usage here:
> 
> drivers/target/target_core_pr.c: In function '__core_scsi3_update_aptpl_buf':
> drivers/target/target_core_pr.c:1955: warning: the frame size of 1116 bytes is larger than 1024 bytes
> 

Hmmm, strange.  I am not seeing this on any of my 32-bit builds..  

Anyways, since __core_scsi3_update_aptpl_buf() is internally holding the
T10_RES(su_dev)->registration_lock while walking
T10_RES(su_dev)->registration_list to build the passed APTPL *buf, this
local scope tmp[1024] can be safetly converted to a
T10_RES(su_dev)->tmp_buf[] and drop the extra stack usage.

Thanks,

--nab

> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


      reply	other threads:[~2010-11-08 21:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-18 22:37 Nicholas A. Bellinger
2010-11-08 14:50 ` Christoph Hellwig
2010-11-08 21:27   ` Nicholas A. Bellinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289251633.27226.66.camel@haakon2.linux-iscsi.org \
    --to=nab@linux-iscsi.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®