From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751448Ab0KIFOw (ORCPT ); Tue, 9 Nov 2010 00:14:52 -0500 Received: from mail-gw0-f46.google.com ([74.125.83.46]:57783 "EHLO mail-gw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750959Ab0KIFOv (ORCPT ); Tue, 9 Nov 2010 00:14:51 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; b=aFglAmEsC0+QtEO8U8zj7/Z92X6rvXOMkdVPJAE3OnWBsIJRT5wZmklAdKNIBPSBMS V9ykxOIpMr1nToChQPCU5wcUze+nBqwALWtlWFzm5N2tTHLQEH24Dm/ODKHedl3oiw3P JfJsvI3ApB8puVLRb6h/jJLEeOe5mZcj7ymjw= Subject: [PATCH] hwmon: (gpio-fan) Fix fan_ctrl_init error path From: Axel Lin To: linux-kernel Cc: Jean Delvare , Guenter Roeck , Simon Guinot , lm-sensors@lm-sensors.org Content-Type: text/plain Date: Tue, 09 Nov 2010 13:18:39 +0800 Message-Id: <1289279919.14461.7.camel@mola> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove sysfs entries before return -ENODEV. Signed-off-by: Axel Lin --- drivers/hwmon/gpio-fan.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/hwmon/gpio-fan.c b/drivers/hwmon/gpio-fan.c index aa701a1..d2e66b4 100644 --- a/drivers/hwmon/gpio-fan.c +++ b/drivers/hwmon/gpio-fan.c @@ -388,11 +388,13 @@ static int fan_ctrl_init(struct gpio_fan_data *fan_data, fan_data->speed_index = get_fan_speed_index(fan_data); if (fan_data->speed_index < 0) { err = -ENODEV; - goto err_free_gpio; + goto err_remove_sysfs; } return 0; +err_remove_sysfs: + sysfs_remove_group(&pdev->dev.kobj, &gpio_fan_ctrl_group); err_free_gpio: for (i = i - 1; i >= 0; i--) gpio_free(ctrl[i]); -- 1.7.2