From: David Daney <ddaney@caviumnetworks.com>
To: linux-kernel@vger.kernel.org
Cc: David Daney <ddaney@caviumnetworks.com>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>
Subject: [PATCH] exec_domain: Establish a Linux32 domain on CONFIG_COMPAT systems.
Date: Tue, 9 Nov 2010 14:59:00 -0800 [thread overview]
Message-ID: <1289343540-8319-1-git-send-email-ddaney@caviumnetworks.com> (raw)
If PER_LINUX32 is set calling sys_personality, we will try to
find the corresponding exec_domain. This causes us to try to load a
module for personality-8. After running the userspace module loader
and failing to find the module, we fall back to the default.
We can avoid the failed module loading overhead by building-in the
linux32_exec_domain for systems that have CONFIG_COMPAT.
I noticed this on MIPS64 systems, but it is a general problem and
applies to x86 among others. Admittedly sys_personality() is probably
not in the hot path of many programs, but the overhead of the extra
exec_domain is fairly small.
Signed-off-by: David Daney <ddaney@caviumnetworks.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Oleg Nesterov <oleg@redhat.com>
---
kernel/exec_domain.c | 14 ++++++++++++++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/kernel/exec_domain.c b/kernel/exec_domain.c
index 0dbeae3..9335495 100644
--- a/kernel/exec_domain.c
+++ b/kernel/exec_domain.c
@@ -34,6 +34,17 @@ static unsigned long ident_map[32] = {
24, 25, 26, 27, 28, 29, 30, 31
};
+#ifdef CONFIG_COMPAT
+static struct exec_domain linux32_exec_domain = {
+ .name = "Linux32", /* name */
+ .handler = default_handler, /* lcall7 causes a seg fault. */
+ .pers_low = PER_LINUX32,
+ .pers_high = PER_LINUX32,
+ .signal_map = ident_map, /* Identity map signals. */
+ .signal_invmap = ident_map, /* - both ways. */
+};
+#endif
+
struct exec_domain default_exec_domain = {
.name = "Linux", /* name */
.handler = default_handler, /* lcall7 causes a seg fault. */
@@ -41,6 +52,9 @@ struct exec_domain default_exec_domain = {
.pers_high = 0, /* PER_LINUX personality. */
.signal_map = ident_map, /* Identity map signals. */
.signal_invmap = ident_map, /* - both ways. */
+#ifdef CONFIG_COMPAT
+ .next = &linux32_exec_domain,
+#endif
};
--
1.7.2.3
reply other threads:[~2010-11-09 22:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289343540-8319-1-git-send-email-ddaney@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®