mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Don Zickus <dzickus@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: fweisbec@gmail.com, gorcunov@openvz.org,
	LKML <linux-kernel@vger.kernel.org>,
	Don Zickus <dzickus@redhat.com>
Subject: [PATCH 0/2] x86: Remove old nmi_watchdog
Date: Fri, 12 Nov 2010 11:22:22 -0500	[thread overview]
Message-ID: <1289578944-28564-1-git-send-email-dzickus@redhat.com> (raw)

Ingo asked me to remove the old nmi_watchdog to minimize the amount of
code duplication we have to do for recent fixes.  All the functionality
needed by the old nmi watchdog should be available in perf now.

This is done in two parts.  The first part is simply remove the old code
and leave stubs for the functions that were removed.  This mimics the
behaviour of the new nmi watchdog.

The second parts removes all the stub functions, which is probably a
little more intrusive, but basically dead code anyway.

The only small piece left is the perf counter reservation code.  That can't
be removed until oprofile is modified to sit on top of perf (if that is
possible).

Compile tested for 32/64 bit with the lockup detector turned on and off.
Tested on 32/64 bit machines to make sure they still boot properly.

NOTE:  This patch will clash with my nmi rewrite patch series.  I don't
which patch series will go in first.  I can refresh either one once one
of them is merged.

Don Zickus (2):
  x86, nmi_watchdog:  remove the old nmi_watchdog
  x86, nmi_watchdog: remove all stub function calls from old
    nmi_watchdog

 arch/x86/include/asm/nmi.h             |   51 ---
 arch/x86/include/asm/smpboot_hooks.h   |    1 -
 arch/x86/include/asm/timer.h           |    6 -
 arch/x86/kernel/apic/Makefile          |    5 +-
 arch/x86/kernel/apic/apic.c            |   15 +-
 arch/x86/kernel/apic/hw_nmi.c          |   16 +-
 arch/x86/kernel/apic/io_apic.c         |   46 ---
 arch/x86/kernel/apic/nmi.c             |  567 ----------------------------
 arch/x86/kernel/cpu/perf_event.c       |    9 -
 arch/x86/kernel/cpu/perfctr-watchdog.c |  642 --------------------------------
 arch/x86/kernel/smpboot.c              |   11 -
 arch/x86/kernel/time.c                 |   18 -
 arch/x86/kernel/traps.c                |   11 -
 arch/x86/oprofile/nmi_timer_int.c      |    3 -
 drivers/acpi/acpica/nsinit.c           |    2 -
 drivers/watchdog/hpwdt.c               |    7 +-
 include/linux/nmi.h                    |    8 +-
 kernel/sysctl.c                        |   16 -
 18 files changed, 7 insertions(+), 1427 deletions(-)
 delete mode 100644 arch/x86/kernel/apic/nmi.c

-- 
1.7.2.3


             reply	other threads:[~2010-11-12 16:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-12 16:22 Don Zickus [this message]
2010-11-12 16:22 ` [PATCH 1/2] x86, nmi_watchdog: remove the " Don Zickus
2010-11-18 14:05   ` [tip:perf/core] x86, nmi_watchdog: Remove " tip-bot for Don Zickus
2010-11-18 19:11     ` Yinghai Lu
2010-11-18 19:39       ` Yinghai Lu
2010-11-18 20:02         ` Don Zickus
2010-11-18 20:07           ` Yinghai Lu
2010-11-12 16:22 ` [PATCH 2/2] x86, nmi_watchdog: remove all stub function calls from " Don Zickus
2010-11-18 14:05   ` [tip:perf/core] x86, nmi_watchdog: Remove " tip-bot for Don Zickus
2010-11-12 18:04 ` [PATCH 0/2] x86: Remove " Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289578944-28564-1-git-send-email-dzickus@redhat.com \
    --to=dzickus@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=gorcunov@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome