From: Todd Poynor <toddpoynor@google.com>
To: linux-kernel@vger.kernel.org
Cc: srostedt@redhat.com, Todd Poynor <toddpoynor@google.com>
Subject: [PATCH] preemptoff tracer: trace the preempt enable at preempt_schedule
Date: Fri, 12 Nov 2010 16:24:16 -0800 [thread overview]
Message-ID: <1289607856-29995-1-git-send-email-toddpoynor@google.com> (raw)
preempt_schedule() uses the _notrace versions of the preemption
disable/enable routines for setting the PREEMPT_ACTIVE flag to avoid
a race condition per commit d1f74e2. This causes the preemptoff
trace to not be properly terminated when the preempted thread is
rescheduled. Since the original fix only converted the preempt
re-enable to use the _notrace version for symmetry, call the tracing
version instead. The corresponding preemptoff start will be
traced by the preempt_disable() in schedule(), although this may
be relying on a fragile state of affairs, and it may be best to also
add a direct call to trace a preempt disable after preemption is
safely disabled and the race avoided.
Signed-off-by: Todd Poynor <toddpoynor@google.com>
---
kernel/sched.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index aa14a56..de83e30 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -4041,7 +4041,7 @@ asmlinkage void __sched notrace preempt_schedule(void)
do {
add_preempt_count_notrace(PREEMPT_ACTIVE);
schedule();
- sub_preempt_count_notrace(PREEMPT_ACTIVE);
+ sub_preempt_count(PREEMPT_ACTIVE);
/*
* Check again in case we missed a preemption opportunity
--
1.7.3.1
reply other threads:[~2010-11-13 0:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289607856-29995-1-git-send-email-toddpoynor@google.com \
--to=toddpoynor@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®