Re: [RFC][PATCH 1/5] [PATCH 1/5] events: Add EVENT_FS the event filesystem

[Steven Rostedt <rostedt@goodmis.org>]

On Tue, 2010-11-16 at 19:32 -0800, Greg KH wrote:
> On Tue, Nov 16, 2010 at 07:53:58PM -0500, Steven Rostedt wrote:
> > From: Steven Rostedt <srostedt@redhat.com>
> > 
> > Copied mostly from debugfs, the eventfs is the filesystem
> > that will include stable tracepoints. Currently nothing
> > enables this filesystem as of this patch.
> 
> What?  Wait, I wrote tracefs a long time ago just for this, why not take
> that code and use it instead?


Because:

1) I couldn't find it (I thought you called it eventfs, so I was
searching for the wrong thing).

2) You never answered your ping on IRC

3) I was in a rush to get something out.

;-)


I'm perfectly fine in swapping this out. This is only an RFC anyway.
This is also why I Cc'd you on this patch.



> 
> {sigh}  And I just deleted that old tracefs git tree today as I thought
> that idea was long gone and dead....

{sigh} and it may still be dead :-(

-- Steve

> 
> > 
> > Cc: Greg KH <gregkh@suse.de>
> > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> > ---
> >  fs/Kconfig              |    6 +
> >  fs/Makefile             |    1 +
> >  fs/eventfs/Makefile     |    4 +
> >  fs/eventfs/file.c       |   53 ++++++
> >  fs/eventfs/inode.c      |  433 +++++++++++++++++++++++++++++++++++++++++++++++
> 
> This seems a bit big, I don't think you need all of this for some
> reason.  Are you sure you can't make it smaller?
> 
> thanks,
> 
> greg k-h