From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751665AbdJDRSf (ORCPT ); Wed, 4 Oct 2017 13:18:35 -0400 Received: from mail-co1nam03on0048.outbound.protection.outlook.com ([104.47.40.48]:11680 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751335AbdJDRSd (ORCPT ); Wed, 4 Oct 2017 13:18:33 -0400 Cc: brijesh.singh@amd.com, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Joerg Roedel , Tom Lendacky Subject: Re: [Part2 PATCH v5 08/31] KVM: Introduce KVM_MEMORY_ENCRYPT_REGISTER_REGION ioctl To: Borislav Petkov References: <20171004131412.13038-1-brijesh.singh@amd.com> <20171004131412.13038-9-brijesh.singh@amd.com> <20171004151932.ama7jg6jv5w65fan@pd.tnic> From: Brijesh Singh Message-ID: <128f8fd1-52e7-e9a7-5bb0-317540e2f449@amd.com> Date: Wed, 4 Oct 2017 12:18:24 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171004151932.ama7jg6jv5w65fan@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR08CA0056.namprd08.prod.outlook.com (10.173.236.30) To SN1PR12MB0160.namprd12.prod.outlook.com (10.162.3.147) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: de015b9a-0547-4052-3030-08d50b4beefb X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:SN1PR12MB0160; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0160;3:pIgvfc4pGNgF7DaEnXykiHucptaP7PbyttaRdyKwfgcv1pxEnMNisOh6snHEbgkVzOLespsOC/Wbg4f/d2snQIGci+/SYFs08U5hO7srgZ8Yufm8Vy+vaC0iU/Xbgz93w495RtsKM2xTesm7bwtU0P0MtlmkXWVgsywU+wMo+DwtI4c6lsmXFeMiRZI+ARz1jS1/Bdlq+9sdrrW+cQppWk+0dDCTRfR/zj9FHvJr4lxOXRckq0dz62outTvOcDnI;25:KkDIJv/6+TeaELQDLJ6EfS4Qk0Ynsna35EZSMohFIVbVJpVJXZODh31wV4BmtLrIUn3usJLqJjLQGHN569xlA9ymVc8IMvVl3Xv7Q2gk+XDmmMSJyVxGRYVQTZsZyyQ57Hk+0DmkAtM2elGadnWcf71hLBbNMoO/uI+5AerTW7ij8a92D3QI9njeuIybtz2+DPVWsY7EEoIvT28WNz/JQrRsd5NoTWDkF9uwYEbApLbKRv/VahzfvlwCuvj8K/WbSPsYAeIMCCkNpHJENeHAa5dADrZRa1TEs6lmLa4/RlMVItcPhKKExTwxUO0Sv46BKPNMKCkX+a59R8gTWoVnLQ==;31:/boAIocmEdRkAyw6F+bosxuTwKhcQq8uWL6iRYXEgOMzAANbZNWjjOxvb2It56O4vW4715XGJN1TCHN3pb6TQKipG9yAl+6xE89V6qyPobnb7TngP788TaQ/4O89OnVV0Y2AQiCq47eSyYdCthjjTpHo90ayb5pvpb4nSiIj2M7dNFO+JrMEhfAdG/yVYJAU5mCaLW/1ocaD8znTENn/p6hhJv5z5GsNZ2MVj3feU88= X-MS-TrafficTypeDiagnostic: SN1PR12MB0160: X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0160;20:U+1ozupOCQIrq0VueHGngsEOSH7f4yuUZz2VBGIXWg1apsae8XKrR7/9a36HAVrsRk/JKGlnD6ub7oXFh+LJ2IbIPjIPdJqRi6iWjOV6C3305PDlwAjqf8GQ1wNTCFlk3QRJ6uyxgtJap+hq6D3YMV6f0iEWCAKf8M8xHlJqlz26beIpn/WfycTecuMQ+csVJgIiWpJgVykdb1/GFAfzpqMzjdtI7tFHjAfZ20qBiVTI8koQyD/YMOJ6Dutl7L+A1t12uyeXlsrtz3523hWtETwC1XrYy3Bg0bUxWo6dj2NP4Uf38IgZDE0PMgf2hLpE1x7RKiJmWJSXIttsSpb5yR7PCvl1iU9LwqgeJZfu1T9yywJWaNytjwFeg2yejsvRFo7YQInExMj2zkn78aFKZbWfHz+YE6SxZnvvmXN2HiREqZ9bMzf69xJRvX3SqZ0ufdZHH3SV02UC6HodDlB9z/5+d5LGhaYLockPGHpwCxHwKTmdYHdW1tApe8BYBPgC;4:lvMEAsp/IHrjItSsaHXgNdRlsEaYybiS5QE1OLTNdS2TO8Zcj8W4b0kYWznHA/3T4K+gQewr2sX3eG+aTNev0Rnousjffsw3FJhfQU9Vgvzod9A/K0qZMX9BaoOrIOvEc2nnD57XdRPhiH5y6BhSZn4H9qnQ791wmQIObytrnS/OETevM8Gp6KWQkvwxFeGsYKnQP+WcxPLHvKyYJkpQMza1tZ9q3d+cvV83szLzrFX1DtAeJZxbQ+CUxbynjzM8 X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123562025)(20161123555025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:SN1PR12MB0160;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:SN1PR12MB0160; X-Forefront-PRVS: 0450A714CB X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(39860400002)(346002)(376002)(51914003)(199003)(189002)(24454002)(377454003)(43544003)(97736004)(23676002)(86362001)(76176999)(53936002)(6246003)(50986999)(54356999)(3846002)(6116002)(478600001)(64126003)(47776003)(33646002)(101416001)(36756003)(77096006)(230700001)(90366009)(6486002)(66066001)(65956001)(189998001)(68736007)(105586002)(229853002)(65806001)(83506001)(50466002)(4326008)(54906003)(8936002)(53546010)(305945005)(7736002)(6666003)(81166006)(5660300001)(81156014)(58126008)(25786009)(16576012)(2906002)(8676002)(31696002)(31686004)(65826007)(2950100002)(7416002)(6916009)(106356001)(16526018)(316002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0160;H:[10.236.136.62];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTYwOzIzOmNGZS9sb1dhcWpwZzBJc0hzSyt4enR1RGI0?= =?utf-8?B?c3lMTTJqRnZoWitMekJiVU1hejlqWktBOXhJQStNV3UzNnZqUWtvVmdDNmFJ?= =?utf-8?B?bXQrb3A5VExMSUlqajRRbjhhM3ZaKy9vNkJXWm05ZDJIeWpHWk82bDh5cnRq?= =?utf-8?B?eDUya3gvR2dKaytodEZIZUpwS3pJWkJxQ3JoVXpYMXFvWnhlUFFtc3hnNi9F?= =?utf-8?B?dmZyV1FvdHlqNmp1S2ZZYlRBNGRYdnhWN0sxbnBvTHBtTHdtc0xIRGtNYU5v?= =?utf-8?B?MGZ3ejNLZGpXNzBucG1ZYm5kZy96Rk93TTQzK0pYMTlPaVdFR2hUcjh6ZEEx?= =?utf-8?B?WGMwTDBQZDhJU2hZbTh0aVkrVkxvY3hxRjBHekx1SHJEc0o2UlQ4QTJrRHJL?= =?utf-8?B?eElSOVc0eFczZEFUdUtORnh4dWFDbDFLRkIyZ3YrakFSSzRkKzFibTJGeVlV?= =?utf-8?B?b0Q2dE52Q2hPd3lKYmdTVXJzcnpQRGhjV3Z1a3VhOXRzUGFYSzd1Q01lMElG?= =?utf-8?B?ZElUSGYvYXRZNmw5RHE5bFJEcUFHT0N5c3BlYlZra2NPWTdNKzQrTzhFd2ZO?= =?utf-8?B?b1o0emtRUnl5NllCck5QV3RRRFUwK1NMWjFOTGlpaHJqUG9zNjdPSG9MWnZZ?= =?utf-8?B?V2kyM0N6cWNXRWJoK1VvZ1NtVHJrWG44enprbXg4K3pidHFmUzdyVXEra3JD?= =?utf-8?B?QUNGelF1dTJxYWlNUkp4UnA2SmVmZll4QmhXVTJsaWpKWFc1OWJTVGlERCtE?= =?utf-8?B?R0g5NGdzSElrbUtiUzJJdStmTGpyWUt1UTNQOFZ4eFRQZGZyckpURVFLakhC?= =?utf-8?B?RVlRaFZvRTV4QkdoV1NvTEUyK3R4QlB3SGNpZTdwanJ1Wjc3RGRnTjZyUG1j?= =?utf-8?B?amdkekUvVjV0Qi80R1NIcVh6ZjhwQ1NHb3dncDhoVG5ZMGJlTmIvTWpoYmF5?= =?utf-8?B?QUpTNGx4ZE5KcCsyMXVHQWdOMmdoZWJmNTI4Yk1RTXRDajRYWm5KU0I5OGVC?= =?utf-8?B?T0hFQlVXL2M2MlpEUzFhWkNNT1M4Y0RaRFQyZ0EvT2VGYnIvT0l0bTI3SDYw?= =?utf-8?B?Ymw4VXZJc2FTWlBrK21SKzRnM1Jxd1JtUXlnT1VkcmNFaDByOTZPd3JQdDZU?= =?utf-8?B?cG01NUNicFNLRVZKUzNubnlpWnFVVUpKV0VIR1V4Rmd6QzRoTi9BWHNHV25Q?= =?utf-8?B?anNOcXk4WndaNGsvVTVORlVtM3VWSjRpN0pURjhUa296a3p1YW4xbk5rR1Yv?= =?utf-8?B?YzlzNFJVckpBQ2xPeWZ0MkhPQTZXNWJLUm0vRUJvYTNnQmZVYXFXbURrRUsz?= =?utf-8?B?TklaTVlxVFJhUUJRc0JPR3EzTVA1Z0RIcW9lMXY3Q0Nia3FqUlV4MzhCdW9q?= =?utf-8?B?bFNaVG14MkdmOFJnbGZSV3RJeU1CejI5blF4cjR5RkdraDZubFlZK3VvYWFG?= =?utf-8?B?Z09CQzF1WS9EOStDYzJMV09rN3BVYUNYQjU5ZFJiWEN3QklMcDJhZ0FPMC9H?= =?utf-8?B?L1ZHZ1g4MEszY1g1MEdzZzlRRC9GM2RKZlVmTjEwWW1OVXNNUzJYeG1EaDF1?= =?utf-8?B?RXpFbWpGYlN1WUwweXdnTHAwU0hQK053NUY3eXRyRDRvSmhCaWk3TVdNRGtT?= =?utf-8?B?eEdtcEdodXBWc0JEa3Z4TjRMT3RjTjY4NndPRTJGb092aWxXN1RsbFZQa0RC?= =?utf-8?B?VnFxQnpnYjkvMTMxZ2IrR25EaktsYmxDOVpRZ2ptNW0wdWtyS0NQZTdFVjBm?= =?utf-8?B?c2FHVlRHVmhuRXRzYUZxbzdGRm1UdHFhK3ZOSmNYMXoxRFlDSXVDOHZTSEth?= =?utf-8?B?VVl1ZDNoVFJWTVgyWThCMy9KeEFWemJpN0I5NzlUUUdPNllWL2ZqK0ljb05B?= =?utf-8?B?R2wrY1R2eW9qSzVVNXIxcVpDemFNamhzWmpsUGtBUDlZcXJ4WHIxaUd2cUVJ?= =?utf-8?B?Q1FTbUpXbVBicHYrb3RBeE9EN1VIMjhGNkd4Z3ljZG1KYzlIcWVaTFRNdUFF?= =?utf-8?Q?Wt4LDb?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0160;6:FF2GAiypXrfxaTIOoLewrLk9UZcOeYE88GieKi0G9/6CAk1qqSLWBdELHudIK+QHT220oU/l8WOjsYqqKBD3faN9qOv8hYV1h4t5pzkk1mQsEUe/H9r5l/yRiEykuNp+tEU4Phu2zyctWaDakECKJdw1Ve69C0/upTtqc8ijYMBU5gj0VCuVYw+AwMIkqDGu7runbtqqnP4BgzFd4ztpi+ICNv7CpJAyQgr/X8ikxeq+D4qk5D2KhGHezbenBe9u/OillEkeWtesdKvNb5o/SvGHDh1iyWAwSRGXkYHD5UEgUfISg9uOvjt42LpJrj6fDPrxFtz75X++k9AYeWO5GA==;5:09wh3QYNosZYKREkzq+lwreba4S1XVp9x1+McpkdTELU2JTNFCs2wUuoN8RJK/ck37KoGCB7jso2dY1qVMmP+mCzE6r9odXpf/kfFxsNqGV+gppiwUfMobKN5GoMaiWjThs4FsEoP6RUlW9/409plw==;24:DsD5gG1ZE111Wb1cbzCDK2X+LxsbA9A2LX9QG2MNgeMPgAsIF9rU5KQnddTZtMdGZNE5N9ELTfRiV0gVH4FjypwEe2yL9rwX/Lyt3L2xbCw=;7:QhLKjwrCTf71GLEq0B7fTjMvZ/jk1NsgoyMoW1oTQ2VQsh57LmwoIlgIjMH4aiFOCfwPgoPJh7sQKkxOsav4QdD/RkSS2RmHSuQwNHM3bfgBb/M9cFYw49c8bvUm19WfFlBSWgPkIyT7o2N/b6/LHJkuXE196g5nJrYMYQVTyitvXXeVYf5ZTsIXPZ1qJo1x0nuU76x9m9sn2KmQTHQ7ows/rVObcI9LNR2d5u06S9c= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0160;20:4/vdErieHrypzS/C8OHKX2PNY4Nr+0ZwrnJGXArGqAii6bdF24FnGXQdCCf/TumlpWCSimcwL570Pt8i9WJaS9q0hjoFuybIqMw3CGO017YdS6wHziIkJy1BG9MgaXAdnzCzGkTDR+pC3FOt+JE5fa9LRTzNHHW0wQ2GtKCTuJMXeamQWxBVq7AxFz8ATqy2EO+VAA5QsBl2e0ludyOXxmJxJl1c6PJtNiDTVfCuJ+YfiRq3BTNl+4gt4wCWvC70 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2017 17:18:28.8780 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/04/2017 10:19 AM, Borislav Petkov wrote: >> +}; >> + >> +#define KVM_MEMORY_ENCRYPT_REGISTER_REGION _IOR(KVMIO, 0xbb,\ >> + struct kvm_enc_region) >> +#define KVM_MEMORY_ENCRYPT_UNREGISTER_REGION _IOR(KVMIO, 0xbc,\ >> + struct kvm_enc_region) > > Yuck, those are needlessly too long. They could be just as understandable if > they were called: > > #define KVM_MEM_ENC_REG_REGION _IOR(KVMIO, 0xbb, struct kvm_enc_region) > #define KVM_MEM_ENC_UNREG_REGION _IOR(KVMIO, 0xbc, struct kvm_enc_region) > > or so... I know, it'll need to change the qemu patches but it is more > compact this way, IMO, and you don't have to break the _IOR line. > Thanks for the patch Boris, I will take care of removing the wrapper from kvm_vm_ioctl_mem_enc_op(). As per shorting the name is concerned, if am open to suggestion. lets see if Paolo or Radim have any comments on naming. If not, then I will shorten the name in next rev. -Brijesh