From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>,
linux-security-module@vger.kernel.org, keyrings@linux-nfs.org,
linux-crypto@vger.kernel.org, David Howells <dhowells@redhat.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
James Morris <jmorris@namei.org>,
David Safford <safford@watson.ibm.com>,
Rajiv Andrade <srajiv@linux.vnet.ibm.com>,
Mimi Zohar <zohar@us.ibm.com>
Subject: [PATCH v1.4 2/5] tpm: add module_put wrapper
Date: Thu, 18 Nov 2010 17:42:43 -0500 [thread overview]
Message-ID: <1290120166-3132-3-git-send-email-zohar@linux.vnet.ibm.com> (raw)
In-Reply-To: <1290120166-3132-1-git-send-email-zohar@linux.vnet.ibm.com>
For readability, define a tpm_chip_put() wrapper to call module_put().
Replace existing module_put() calls with the wrapper.
(Change based on trusted/encrypted patchset review by David Howells.)
Signed-off-by: Mimi Zohar <zohar@us.ibm.com>
Signed-off-by: David Safford <safford@watson.ibm.com>
---
drivers/char/tpm/tpm.c | 4 ++--
drivers/char/tpm/tpm.h | 5 +++++
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm.c b/drivers/char/tpm/tpm.c
index 7c41335..26c09f3 100644
--- a/drivers/char/tpm/tpm.c
+++ b/drivers/char/tpm/tpm.c
@@ -736,7 +736,7 @@ int tpm_pcr_read(u32 chip_num, int pcr_idx, u8 *res_buf)
if (chip == NULL)
return -ENODEV;
rc = __tpm_pcr_read(chip, pcr_idx, res_buf);
- module_put(chip->dev->driver->owner);
+ tpm_chip_put(chip);
return rc;
}
EXPORT_SYMBOL_GPL(tpm_pcr_read);
@@ -775,7 +775,7 @@ int tpm_pcr_extend(u32 chip_num, int pcr_idx, const u8 *hash)
rc = transmit_cmd(chip, &cmd, EXTEND_PCR_RESULT_SIZE,
"attempting extend a PCR value");
- module_put(chip->dev->driver->owner);
+ tpm_chip_put(chip);
return rc;
}
EXPORT_SYMBOL_GPL(tpm_pcr_extend);
diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
index 792868d..72ddb03 100644
--- a/drivers/char/tpm/tpm.h
+++ b/drivers/char/tpm/tpm.h
@@ -113,6 +113,11 @@ struct tpm_chip {
#define to_tpm_chip(n) container_of(n, struct tpm_chip, vendor)
+static inline void tpm_chip_put(struct tpm_chip *chip)
+{
+ module_put(chip->dev->driver->owner);
+}
+
static inline int tpm_read_index(int base, int index)
{
outb(index, base);
--
1.7.2.2
next prev parent reply other threads:[~2010-11-18 22:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 22:42 [PATCH v1.4 0/5] keys: trusted and encrypted keys Mimi Zohar
2010-11-18 22:42 ` [PATCH v1.4 1/5] lib: hex2bin converts ascii hexadecimal string to binary Mimi Zohar
2010-11-18 22:42 ` Mimi Zohar [this message]
2010-11-18 22:42 ` [PATCH v1.4 3/5] key: add tpm_send command Mimi Zohar
2010-11-18 22:42 ` [PATCH v1.4 4/5] keys: add new trusted key-type Mimi Zohar
2010-11-18 22:42 ` [PATCH v1.4 5/5] keys: add new key-type encrypted Mimi Zohar
2010-11-19 15:43 ` [PATCH v1.4 1/5] lib: hex2bin converts ascii hexadecimal string to binary David Howells
2010-11-19 15:43 ` [PATCH v1.4 2/5] tpm: add module_put wrapper David Howells
2010-11-19 15:45 ` [PATCH v1.4 3/5] key: add tpm_send command David Howells
2010-11-19 16:04 ` David Safford
2010-11-19 16:45 ` David Howells
2010-11-19 16:23 ` [PATCH v1.4 4/5] keys: add new trusted key-type David Howells
2010-11-19 18:00 ` David Safford
2010-11-19 16:43 ` [PATCH v1.4 5/5] keys: add new key-type encrypted David Howells
2010-11-22 12:16 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290120166-3132-3-git-send-email-zohar@linux.vnet.ibm.com \
--to=zohar@linux.vnet.ibm.com \
--cc=dhowells@redhat.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=jmorris@namei.org \
--cc=keyrings@linux-nfs.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=safford@watson.ibm.com \
--cc=srajiv@linux.vnet.ibm.com \
--cc=zohar@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome