From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH 1/2] regulator: Fix obfuscated log messages
Date: Mon, 22 Nov 2010 13:51:18 +0000 [thread overview]
Message-ID: <1290433879-6184-1-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
Don't use %s to format fixed static strings into log messages, it just
makes searching for and reading the message in the kernel source
needlessly hard.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/regulator/core.c | 14 ++++++--------
1 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 8d492f4..fe47860 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -760,7 +760,7 @@ static int machine_constraints_voltage(struct regulator_dev *rdev,
/* else require explicit machine-level constraints */
if (cmin <= 0 || cmax <= 0 || cmax < cmin) {
- pr_err("%s '%s' voltage constraints\n", "invalid",
+ pr_err("invalid '%s' voltage constraints\n",
name);
return -EINVAL;
}
@@ -782,22 +782,20 @@ static int machine_constraints_voltage(struct regulator_dev *rdev,
/* final: [min_uV..max_uV] valid iff constraints valid */
if (max_uV < min_uV) {
- pr_err("%s '%s' voltage constraints\n", "unsupportable",
+ pr_err("unsupportable '%s' voltage constraints\n",
name);
return -EINVAL;
}
/* use regulator's subset of machine constraints */
if (constraints->min_uV < min_uV) {
- pr_debug("override '%s' %s, %d -> %d\n",
- name, "min_uV",
- constraints->min_uV, min_uV);
+ pr_debug("override '%s' min_uV, %d -> %d\n",
+ name, constraints->min_uV, min_uV);
constraints->min_uV = min_uV;
}
if (constraints->max_uV > max_uV) {
- pr_debug("override '%s' %s, %d -> %d\n",
- name, "max_uV",
- constraints->max_uV, max_uV);
+ pr_debug("override '%s' max_uV, %d -> %d\n",
+ name, constraints->max_uV, max_uV);
constraints->max_uV = max_uV;
}
}
--
1.7.1
next reply other threads:[~2010-11-22 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 13:51 Mark Brown [this message]
2010-11-22 13:51 ` [PATCH 2/2] regulator: Remove regulator core version announcement Mark Brown
2010-11-22 14:31 ` [PATCH 1/2] regulator: Fix obfuscated log messages Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290433879-6184-1-git-send-email-broonie@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome