From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Wan ZongShun <mcuos.com@gmail.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] ASoC: nuc900-ac97: fix a memory leak
Date: Wed, 24 Nov 2010 10:51:22 +0000 [thread overview]
Message-ID: <1290595882.3332.7.camel@odin> (raw)
In-Reply-To: <1290588263.7545.1.camel@mola>
On Wed, 2010-11-24 at 16:44 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/nuc900/nuc900-ac97.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c
> index 293dc74..e00e39d 100644
> --- a/sound/soc/nuc900/nuc900-ac97.c
> +++ b/sound/soc/nuc900/nuc900-ac97.c
> @@ -384,7 +384,6 @@ out0:
>
> static int __devexit nuc900_ac97_drvremove(struct platform_device *pdev)
> {
> -
> snd_soc_unregister_dai(&pdev->dev);
>
> clk_put(nuc900_ac97_data->clk);
> @@ -392,6 +391,7 @@ static int __devexit nuc900_ac97_drvremove(struct platform_device *pdev)
> release_mem_region(nuc900_ac97_data->res->start,
> resource_size(nuc900_ac97_data->res));
>
> + kfree(nuc900_ac97_data);
> nuc900_ac97_data = NULL;
>
> return 0;
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-11-24 10:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 8:44 Axel Lin
2010-11-24 10:51 ` Liam Girdwood [this message]
2010-11-24 11:31 ` Wan ZongShun
2010-11-24 11:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290595882.3332.7.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcuos.com@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®