From: Slava Pestov <slavapestov@google.com>
To: linux-kernel@vger.kernel.org
Cc: dhsharp@google.com, mrubin@google.com,
Slava Pestov <slavapestov@google.com>
Subject: [PATCH] ftrace: Fix panic when lseek() called on "trace" opened for writing
Date: Wed, 24 Nov 2010 15:13:16 -0800 [thread overview]
Message-ID: <1290640396-24179-1-git-send-email-slavapestov@google.com> (raw)
The file_ops struct for the "trace" special file defined llseek as seq_lseek().
However, if the file was opened for writing only, seq_open() was not called,
and the seek would dereference a null pointer, file->private_data.
This patch introduces a new wrapper for seq_lseek() which checks if the file
descriptor is opened for reading first. If not, it does nothing.
This patch is for Linux 2.6.36.1.
Signed-Off-By: Slava Pestov <slavapestov@google.com>
---
Change-Id: Iaabc50d84fb541c04e3efabd4788cebadbadbb4c
---
kernel/trace/trace.c | 10 +++++++++-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 9ec59f5..7702f5a 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -2320,11 +2320,19 @@ tracing_write_stub(struct file *filp, const char __user *ubuf,
return count;
}
+static loff_t tracing_seek(struct file *file, loff_t offset, int origin)
+{
+ if (file->f_mode & FMODE_READ)
+ return seq_lseek(file, offset, origin);
+ else
+ return 0;
+}
+
static const struct file_operations tracing_fops = {
.open = tracing_open,
.read = seq_read,
.write = tracing_write_stub,
- .llseek = seq_lseek,
+ .llseek = tracing_seek,
.release = tracing_release,
};
--
1.7.3.1
next reply other threads:[~2010-11-24 23:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 23:13 Slava Pestov [this message]
2010-11-24 23:34 ` David Sharp
2010-12-16 8:21 ` [tip:perf/urgent] tracing: " tip-bot for Slava Pestov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290640396-24179-1-git-send-email-slavapestov@google.com \
--to=slavapestov@google.com \
--cc=dhsharp@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mrubin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®