mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: linux-kernel@vger.kernel.org
Cc: sodaville@linutronix.de, x86@kernel.org,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Dirk Brandewie <dirk.brandewie@gmail.com>
Subject: [PATCH 01/11] x86/kernel: remove conditional early remap in parse_e820_ext
Date: Thu, 25 Nov 2010 18:39:51 +0100	[thread overview]
Message-ID: <1290706801-7323-2-git-send-email-bigeasy@linutronix.de> (raw)
In-Reply-To: <1290706801-7323-1-git-send-email-bigeasy@linutronix.de>

parse_setup_data() uses early_memremap() for a PAGE_SIZE mapping in
order to figure out the type & size. If this mapping is not large enough
then parse_e820_ext() will remap this area again via early_ioremap()
since the first mapping is still in use.

This patch attempts to simplify the handling and parse_e820_ext() does
not need to worry about the mapping anymore.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
CC: x86@kernel.org
Signed-off-by: Dirk Brandewie <dirk.brandewie@gmail.com>
---
 arch/x86/include/asm/e820.h |    2 +-
 arch/x86/kernel/e820.c      |    8 +-------
 arch/x86/kernel/setup.c     |   11 +++++++++--
 3 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/arch/x86/include/asm/e820.h b/arch/x86/include/asm/e820.h
index 5be1542..e956492 100644
--- a/arch/x86/include/asm/e820.h
+++ b/arch/x86/include/asm/e820.h
@@ -93,7 +93,7 @@ extern void e820_setup_gap(void);
 extern int e820_search_gap(unsigned long *gapstart, unsigned long *gapsize,
 			unsigned long start_addr, unsigned long long end_addr);
 struct setup_data;
-extern void parse_e820_ext(struct setup_data *data, unsigned long pa_data);
+extern void parse_e820_ext(struct setup_data *data);
 
 #if defined(CONFIG_X86_64) || \
 	(defined(CONFIG_X86_32) && defined(CONFIG_HIBERNATION))
diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
index 0c2b7ef..33f6361 100644
--- a/arch/x86/kernel/e820.c
+++ b/arch/x86/kernel/e820.c
@@ -666,21 +666,15 @@ __init void e820_setup_gap(void)
  * boot_params.e820_map, others are passed via SETUP_E820_EXT node of
  * linked list of struct setup_data, which is parsed here.
  */
-void __init parse_e820_ext(struct setup_data *sdata, unsigned long pa_data)
+void __init parse_e820_ext(struct setup_data *sdata)
 {
-	u32 map_len;
 	int entries;
 	struct e820entry *extmap;
 
 	entries = sdata->len / sizeof(struct e820entry);
-	map_len = sdata->len + sizeof(struct setup_data);
-	if (map_len > PAGE_SIZE)
-		sdata = early_ioremap(pa_data, map_len);
 	extmap = (struct e820entry *)(sdata->data);
 	__append_e820_map(extmap, entries);
 	sanitize_e820_map(e820.map, ARRAY_SIZE(e820.map), &e820.nr_map);
-	if (map_len > PAGE_SIZE)
-		early_iounmap(sdata, map_len);
 	printk(KERN_INFO "extended physical RAM map:\n");
 	e820_print_map("extended");
 }
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 000e4a1..52f10e6 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -429,16 +429,23 @@ static void __init parse_setup_data(void)
 		return;
 	pa_data = boot_params.hdr.setup_data;
 	while (pa_data) {
+		u32 len;
+
 		data = early_memremap(pa_data, PAGE_SIZE);
+		len = data->len + sizeof(struct setup_data);
+		early_iounmap(data, PAGE_SIZE);
+
+		data = early_memremap(pa_data, len);
+
 		switch (data->type) {
 		case SETUP_E820_EXT:
-			parse_e820_ext(data, pa_data);
+			parse_e820_ext(data);
 			break;
 		default:
 			break;
 		}
 		pa_data = data->next;
-		early_iounmap(data, PAGE_SIZE);
+		early_iounmap(data, len);
 	}
 }
 
-- 
1.7.3.2


  reply	other threads:[~2010-11-25 17:43 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-25 17:39 Add device tree support for x86 Sebastian Andrzej Siewior
2010-11-25 17:39 ` Sebastian Andrzej Siewior [this message]
2010-12-08  8:38   ` [sodaville] [PATCH 01/11] x86/kernel: remove conditional early remap in parse_e820_ext Sebastian Andrzej Siewior
2010-12-08 14:15     ` Thomas Gleixner
2010-12-15 23:28   ` H. Peter Anvin
2010-12-16  9:55     ` Sebastian Andrzej Siewior
2010-11-25 17:39 ` [PATCH 02/11] x86: Add device tree support Sebastian Andrzej Siewior
2010-11-25 22:53   ` Sam Ravnborg
2010-11-26  9:06     ` Sebastian Andrzej Siewior
2010-11-26 21:42   ` Benjamin Herrenschmidt
2010-11-28 13:49     ` Sebastian Andrzej Siewior
2010-11-28 22:28       ` Benjamin Herrenschmidt
2010-12-30  8:26       ` Grant Likely
2010-12-30  8:45         ` Rob Landley
2010-12-30 20:58           ` Grant Likely
2011-01-03 16:05             ` [sodaville] " H. Peter Anvin
2011-01-03 16:19               ` H. Peter Anvin
2011-01-03 17:52                 ` Grant Likely
2011-01-03 18:06                   ` H. Peter Anvin
2011-01-03 18:10                     ` H. Peter Anvin
2010-12-30 20:57         ` Grant Likely
2010-12-31  0:51         ` [sodaville] " H. Peter Anvin
2010-11-25 17:39 ` [PATCH 03/11] x86/dtb: Add a device tree for CE4100 Sebastian Andrzej Siewior
2010-11-26 21:57   ` Benjamin Herrenschmidt
2010-11-28 16:04     ` Sebastian Andrzej Siewior
2010-11-28 22:53       ` Benjamin Herrenschmidt
2010-11-29  1:34         ` Mitch Bradley
2010-11-29 18:26           ` [sodaville] " H. Peter Anvin
2010-11-29 20:03             ` Benjamin Herrenschmidt
2010-11-29 19:44           ` Sebastian Andrzej Siewior
2010-12-02  0:40             ` David Gibson
2010-11-29 19:07         ` Scott Wood
2010-11-29 20:05           ` Benjamin Herrenschmidt
2010-11-29 20:32             ` Mitch Bradley
2010-11-29 20:44               ` Benjamin Herrenschmidt
2010-11-29 21:32                 ` Mitch Bradley
2010-11-29 23:47                 ` Alan Cox
2010-11-30  2:50                   ` Benjamin Herrenschmidt
2010-11-30 11:20                     ` Sebastian Andrzej Siewior
2010-11-29 23:42               ` Alan Cox
2010-11-30 21:18                 ` [sodaville] " H. Peter Anvin
2010-11-30 11:51               ` Sebastian Andrzej Siewior
2010-11-30 20:31                 ` Benjamin Herrenschmidt
2010-11-29 23:58           ` David Gibson
2010-11-29 19:36         ` [sodaville] " Sebastian Andrzej Siewior
2010-11-29 20:14           ` Benjamin Herrenschmidt
2010-11-29  2:22     ` David Gibson
2010-11-25 17:39 ` [PATCH 04/11] x86/dtb: add irq host abstraction Sebastian Andrzej Siewior
2010-11-25 19:30   ` Jon Loeliger
2010-11-26 14:19     ` Sebastian Andrzej Siewior
2010-11-26 21:36       ` Benjamin Herrenschmidt
2010-12-01 10:31         ` [sodaville] " Sebastian Andrzej Siewior
2010-11-27  3:11       ` Jon Loeliger
2010-11-25 17:39 ` [PATCH 05/11] x86/dtb: add early parsing of APIC and IO APIC Sebastian Andrzej Siewior
2010-11-25 17:39 ` [PATCH 06/11] x86/dtb: add support hpet Sebastian Andrzej Siewior
2010-11-25 17:39 ` [PATCH 07/11] x86/dtb: add support for PCI devices backed by dtb nodes Sebastian Andrzej Siewior
2010-11-27 22:33   ` Benjamin Herrenschmidt
2010-11-28 14:04     ` Sebastian Andrzej Siewior
2010-11-28 22:32       ` Benjamin Herrenschmidt
2010-12-02 16:17         ` Sebastian Andrzej Siewior
2010-11-25 17:39 ` [PATCH 08/11] x86/dtb: Add generic bus probe Sebastian Andrzej Siewior
2010-11-25 17:39 ` [PATCH 09/11] x86/ioapic: Add OF bindings for IO-APIC Sebastian Andrzej Siewior
2010-11-25 17:40 ` [PATCH 10/11] x86/io_apic: add simply id set Sebastian Andrzej Siewior
2010-11-25 21:04   ` Yinghai Lu
2010-11-26 11:03     ` Sebastian Andrzej Siewior
2010-11-26 16:50     ` [PATCH] x86/io_apic: split setup_ioapic_ids_from_mpc() into a non-checkign version Sebastian Andrzej Siewior
2010-12-06 13:33       ` [tip:x86/apic] x86: io_apic: Split setup_ioapic_ids_from_mpc() tip-bot for Sebastian Andrzej Siewior
2010-12-07  8:59         ` [PATCH -v2] x86, ioapic: Don't write io_apic ID if it is not changed Yinghai Lu
2010-12-09 20:56           ` [tip:x86/apic-cleanups] x86, ioapic: Avoid writing io_apic id if already correct tip-bot for Yinghai Lu
2010-11-25 17:40 ` [PATCH 11/11] x86/ce4100: use OF for ioapic Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290706801-7323-2-git-send-email-bigeasy@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=dirk.brandewie@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sodaville@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®