From: Dongdong Deng <libfetion@gmail.com>
To: jason.wessel@windriver.com
Cc: kgdb-bugreport@lists.sourceforge.net,
linux-kernel@vger.kernel.org, libfetion@gmail.com
Subject: [PATCH] debug_core: cleanup kgdb_cpu_enter() that removing smp_mb()
Date: Fri, 26 Nov 2010 17:14:58 +0800 [thread overview]
Message-ID: <1290762898-26978-1-git-send-email-libfetion@gmail.com> (raw)
Commit dfee3a7b92208b30f77876068aece9ea571270c2(debug_core:
refactor locking for master/slave cpus) uses spin_lock to replace
the atomic counter lock mechanism, and most kgdb data was designed
to per-cpu, thus the 'smp_mb()' operation is useless here now.
Signed-off-by: Dongdong Deng <libfetion@gmail.com>
---
kernel/debug/debug_core.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c
index 722968f..1b019b5 100644
--- a/kernel/debug/debug_core.c
+++ b/kernel/debug/debug_core.c
@@ -492,9 +492,6 @@ acquirelock:
kgdb_info[cpu].ret_state = 0;
kgdb_info[cpu].irq_depth = hardirq_count() >> HARDIRQ_SHIFT;
- /* Make sure the above info reaches the primary CPU */
- smp_mb();
-
if (exception_level == 1) {
if (raw_spin_trylock(&dbg_master_lock))
atomic_xchg(&kgdb_active, cpu);
--
1.6.0.4
reply other threads:[~2010-11-26 9:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290762898-26978-1-git-send-email-libfetion@gmail.com \
--to=libfetion@gmail.com \
--cc=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome