From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754059Ab0KZJmI (ORCPT ); Fri, 26 Nov 2010 04:42:08 -0500 Received: from service87.mimecast.com ([94.185.240.25]:33407 "HELO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753760Ab0KZJmG convert rfc822-to-8bit (ORCPT ); Fri, 26 Nov 2010 04:42:06 -0500 Subject: Re: [RFC][PATCH 2/8] perf, arch: Use early_initcall() for all arch pmu implementations From: Will Deacon To: Peter Zijlstra Cc: Ingo Molnar , Lin Ming , Stephane Eranian , "robert.richter" , Corey Ashford , fweisbec , paulus , Greg Kroah-Hartman , Kay Sievers , "H. Peter Anvin" , Kyle Moffett , linux-kernel@vger.kernel.org, davem , Michael Cree , Deng-Cheng Zhu , Paul Mundt , Don Zickus , Jason Wessel In-Reply-To: <1290707759.2145.119.camel@laptop> References: <20101117221730.002627458@chello.nl> <20101117222056.040309789@chello.nl> <1290680713.2145.18.camel@laptop> <1290707759.2145.119.camel@laptop> Date: Fri, 26 Nov 2010 09:41:50 +0000 Message-ID: <1290764510.24565.6.camel@e102144-lin.cambridge.arm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 X-OriginalArrivalTime: 26 Nov 2010 09:41:51.0830 (UTC) FILETIME=[27683F60:01CB8D4E] X-MC-Unique: 110112609415901501 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2010-11-25 at 17:55 +0000, Peter Zijlstra wrote: > So the perf_event_init() site is _waaay_ to early to init stuff.. I > guess I'll move it all to early_initcall() and I'll move the watchdog to > an explicit call right after it. > > Something like the below,.. now I guess the question to all of you is, > can your arch pmu code cope with early_initcall() or does it need to be > some other place? > The ARM init code basically just parses the CPUID to work out what PMU is available, so it should be safe to call it as early as you like. Will