From: Peter Huewe <peterhuewe@gmx.de>
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Mark Allyn <mark.a.allyn@intel.com>,
Alan Cox <alan@linux.intel.com>,
Ben Hutchings <ben@decadent.org.uk>,
Joe Perches <joe@perches.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Peter Huewe <peterhuewe@gmx.de>
Subject: [PATCH 1/3] staging/sep: Fix sparse warning 'do-while statement is not a compound statement'
Date: Thu, 2 Dec 2010 00:43:32 +0100 [thread overview]
Message-ID: <1291247014-21525-1-git-send-email-peterhuewe@gmx.de> (raw)
In-Reply-To: <20101201225214.GA15796@kroah.com>
This patch fixes the warning generated by sparse: 'do-while statement is
not a compound statement' by adding the necessary brackets around the do
block
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
KernelVersion: linux-next-20101202
drivers/staging/sep/sep_dev.h | 4 ++--
drivers/staging/sep/sep_driver.c | 12 ++++++------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/sep/sep_dev.h b/drivers/staging/sep/sep_dev.h
index 7b4993b..0ffe68c 100644
--- a/drivers/staging/sep/sep_dev.h
+++ b/drivers/staging/sep/sep_dev.h
@@ -147,9 +147,9 @@ static inline u32 sep_read_reg(struct sep_device *dev, int reg)
static inline void sep_wait_sram_write(struct sep_device *dev)
{
u32 reg_val;
- do
+ do {
reg_val = sep_read_reg(dev, HW_SRAM_DATA_READY_REG_ADDR);
- while (!(reg_val & 1));
+ } while (!(reg_val & 1));
}
diff --git a/drivers/staging/sep/sep_driver.c b/drivers/staging/sep/sep_driver.c
index 7633111..d734887 100644
--- a/drivers/staging/sep/sep_driver.c
+++ b/drivers/staging/sep/sep_driver.c
@@ -2587,9 +2587,9 @@ static int sep_start_handler(struct sep_device *sep)
dev_dbg(&sep->pdev->dev, "sep_start_handler start\n");
/* Wait in polling for message from SEP */
- do
+ do {
reg_val = sep_read_reg(sep, HW_HOST_SEP_HOST_GPR3_REG_ADDR);
- while (!reg_val);
+ } while (!reg_val);
/* Check the value */
if (reg_val == 0x1)
@@ -2754,9 +2754,9 @@ static int sep_init_handler(struct sep_device *sep, unsigned long arg)
/* Wait for acknowledge */
dev_dbg(&sep->pdev->dev, "init; waiting for msg response\n");
- do
+ do {
reg_val = sep_read_reg(sep, HW_HOST_SEP_HOST_GPR3_REG_ADDR);
- while (!(reg_val & 0xFFFFFFFD));
+ } while (!(reg_val & 0xFFFFFFFD));
if (reg_val == 0x1) {
dev_warn(&sep->pdev->dev, "init; device int failed\n");
@@ -2774,9 +2774,9 @@ static int sep_init_handler(struct sep_device *sep, unsigned long arg)
/* Wait for response */
dev_dbg(&sep->pdev->dev, "init; waiting for zero set response\n");
- do
+ do {
reg_val = sep_read_reg(sep, HW_HOST_SEP_HOST_GPR3_REG_ADDR);
- while (reg_val != 0);
+ } while (reg_val != 0);
end_function:
dev_dbg(&sep->pdev->dev, "init is done\n");
--
1.7.2.2
next prev parent reply other threads:[~2010-12-01 23:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 21:31 Peter Huewe
2010-11-29 21:31 ` [PATCH 2/3] staging/sep: Fix sparse warning 'Using plain integer as NULL pointer' Peter Huewe
2010-11-29 21:31 ` [PATCH 3/3] staging/sep: Fix sparse printk format warning Peter Huewe
2010-11-29 21:49 ` Randy Dunlap
2010-11-29 21:59 ` Peter Hüwe
2010-11-29 22:01 ` Randy Dunlap
2010-11-29 23:18 ` Jiri Slaby
2010-12-01 22:52 ` [PATCH 1/3] staging: sep: Fix sparse warning 'do-while statement is not a compound statement' Greg KH
2010-12-01 23:43 ` Peter Huewe [this message]
2010-12-01 23:43 ` [PATCH 2/3] staging/sep: Fix sparse warning 'Using plain integer as NULL pointer' Peter Huewe
2010-12-01 23:43 ` [PATCH 3/3] staging/sep: Fix printk format warning Peter Huewe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291247014-21525-1-git-send-email-peterhuewe@gmx.de \
--to=peterhuewe@gmx.de \
--cc=alan@linux.intel.com \
--cc=ben@decadent.org.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.a.allyn@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®