From: Neil Horman <nhorman@tuxdriver.com>
To: linux-kernel@vger.kernel.org
Cc: Neil Horman <nhorman@tuxdriver.com>,
linux-pci@vger.kernel.org, kexec@lists.infradead.org,
Vivek Goyal <vgoyal@redhat.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: [PATCH] Update MCP55 quirk to not affect non HyperTransport variants
Date: Wed, 8 Dec 2010 09:47:48 -0500 [thread overview]
Message-ID: <1291819668-15624-1-git-send-email-nhorman@tuxdriver.com> (raw)
I wrote this quirk awhile ago to properly setup MCP55 chips on hypertransport
busses so that interrupts reached whatever cpu happend to boot the kdump kernel.
while that works well, it was recently shown to me that a a non-hypertransport
variant of the MCP55 exists, and on those system the register that this quirk
manipulates causes hangs if you write to it. Since the quirk was only meant to
handle errors found on MCP55 chips that have a HT interface, this patch adds a
filter to make sure the chip is an HT capable before making the needed register
adjustment. This lets the broken MCP55s work with kdump while not breaking the
non-HT variants.
Resolves https://bugzilla.kernel.org/show_bug.cgi?id=23952
Tested successfully by the reporter and myself.
Reported-by: Mathieu Bérard <mathieu@mberard.eu>
CC: linux-pci@vger.kernel.org
CC: kexec@lists.infradead.org
CC: Vivek Goyal <vgoyal@redhat.com>
CC: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
---
drivers/pci/quirks.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 6f9350c..313c0bd 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -2329,6 +2329,9 @@ static void __devinit nvbridge_check_legacy_irq_routing(struct pci_dev *dev)
{
u32 cfg;
+ if (!pci_find_capability(dev, PCI_CAP_ID_HT))
+ return;
+
pci_read_config_dword(dev, 0x74, &cfg);
if (cfg & ((1 << 2) | (1 << 15))) {
--
1.7.2.3
next reply other threads:[~2010-12-08 14:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 14:47 Neil Horman [this message]
2010-12-08 16:44 ` Vivek Goyal
2010-12-08 17:21 ` Neil Horman
2010-12-09 23:40 ` Andrew Morton
2010-12-10 11:54 ` Neil Horman
2010-12-10 20:32 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291819668-15624-1-git-send-email-nhorman@tuxdriver.com \
--to=nhorman@tuxdriver.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®