mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Huewe <peterhuewe@gmx.de>
To: Matthew Garrett <mjg@redhat.com>
Cc: platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>
Subject: [PATCH] platform/x86: Fix recursive Kconfig dependency
Date: Thu,  9 Dec 2010 00:29:30 +0100	[thread overview]
Message-ID: <1291850970-7190-1-git-send-email-peterhuewe@gmx.de> (raw)

This patch removes a recursive dependency which causes a build failure
[1-3] by changing the ASUS_WMI from select ACPI_WMI to depend on
ACPI_WMI as most other _WMI config options do.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
Error Message:
drivers/platform/x86/Kconfig:422:error: recursive dependency detected!
drivers/platform/x86/Kconfig:422:	symbol EEEPC_WMI depends on ACPI_WMI
drivers/platform/x86/Kconfig:438:	symbol ACPI_WMI is selected by ACER_WMI
drivers/platform/x86/Kconfig:18:	symbol ACER_WMI depends on LEDS_CLASS
drivers/leds/Kconfig:10:	symbol LEDS_CLASS is selected by EEEPC_WMI


References:
[1] http://kisskb.ellerman.id.au/kisskb/buildresult/3607123/
[2] http://kisskb.ellerman.id.au/kisskb/buildresult/3607218/
[3] http://kisskb.ellerman.id.au/kisskb/buildresult/3607139/

KernelVersion: linux-next-20101208

 drivers/platform/x86/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 4c7f8b9..ddf384a 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -23,7 +23,7 @@ config ACER_WMI
 	depends on BACKLIGHT_CLASS_DEVICE
 	depends on SERIO_I8042
 	depends on RFKILL || RFKILL = n
-	select ACPI_WMI
+	depends on ACPI_WMI
 	---help---
 	  This is a driver for newer Acer (and Wistron) laptops. It adds
 	  wireless radio and bluetooth control, and on some laptops,
-- 
1.7.2.2


             reply	other threads:[~2010-12-08 23:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-08 23:29 Peter Huewe [this message]
2010-12-15 20:35 ` Peter Hüwe
2010-12-15 20:49   ` Corentin Chary
2010-12-15 20:51     ` Randy Dunlap
2010-12-15 21:14       ` Peter Hüwe
2010-12-17 11:30         ` Sedat Dilek
2010-12-19 19:00           ` Peter Hüwe
2010-12-20 14:46             ` Sedat Dilek
2010-12-20 17:09               ` Peter Hüwe
2010-12-20 17:24                 ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291850970-7190-1-git-send-email-peterhuewe@gmx.de \
    --to=peterhuewe@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®