mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ian Munsie <imunsie@au1.ibm.com>, Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <peterz@infradead.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 03/10] perf session: Dont queue events w/o timestamps
Date: Thu,  9 Dec 2010 16:12:50 -0200	[thread overview]
Message-ID: <1291918376-18261-4-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1291918376-18261-1-git-send-email-acme@infradead.org>

From: Thomas Gleixner <tglx@linutronix.de>

If the event has no timestamp assigned then the parse code sets it to
~0ULL which causes the ordering code to enqueue it at the end.

Process it right away.

Reported-by: Ian Munsie <imunsie@au1.ibm.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ian Munsie <imunsie@au1.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <peterz@infradead.org>
LKML-Reference: <20101207124550.528788441@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/session.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index b3b145a..e5d0ed9 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -603,7 +603,7 @@ static int perf_session_queue_event(struct perf_session *s, event_t *event,
 	u64 timestamp = data->time;
 	struct sample_queue *new;
 
-	if (!timestamp)
+	if (!timestamp || timestamp == ~0ULL)
 		return -ETIME;
 
 	if (timestamp < s->ordered_samples.last_flush) {
-- 
1.6.2.5


  parent reply	other threads:[~2010-12-09 18:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-09 18:12 [GIT PULL 00/10] perf/core improvements Arnaldo Carvalho de Melo
2010-12-09 18:12 ` [PATCH 01/10] perf report: Allow user to specify path to kallsyms file Arnaldo Carvalho de Melo
2010-12-09 18:12 ` [PATCH 02/10] perf event: Prevent unbound event__name array access Arnaldo Carvalho de Melo
2010-12-09 18:12 ` Arnaldo Carvalho de Melo [this message]
2010-12-09 18:12 ` [PATCH 04/10] perf session: Consolidate the dump code Arnaldo Carvalho de Melo
2010-12-09 18:12 ` [PATCH 05/10] perf session: Store file offset in sample_queue Arnaldo Carvalho de Melo
2010-12-09 18:12 ` [PATCH 06/10] perf session: Add file_offset to event delivery function Arnaldo Carvalho de Melo
2010-12-09 18:12 ` [PATCH 07/10] perf session: Move dump code to event delivery path Arnaldo Carvalho de Melo
2010-12-09 18:12 ` [PATCH 08/10] perf session: Split out sample preprocessing Arnaldo Carvalho de Melo
2010-12-09 18:12 ` [PATCH 09/10] perf session: Split out user event processing Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291918376-18261-4-git-send-email-acme@infradead.org \
    --to=acme@infradead.org \
    --cc=acme@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=imunsie@au1.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®