From: Anton Arapov <aarapov@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: "Changli Gao <xiaosuo@gmail.com>; Andrew Morton
<akpm@linux-foundation.org>; Linus Torvalds"
<torvalds@linux-foundation.org>,
Anton Arapov <aarapov@redhat.com>
Subject: [PATCH] lib: fix vscnprintf() if @size is == 0
Date: Mon, 13 Dec 2010 15:05:19 +0100 [thread overview]
Message-ID: <1292249119-21600-1-git-send-email-aarapov@redhat.com> (raw)
vscnprintf() should return 0 if @size is == 0. Update the comment for it,
as @size is unsigned.
This change based on the code of commit b903c0b8899b46829a9b80ba55b61079b35940ec
moves the real fix into vscnprinf() from scnprintf() and makes scnprintf() call
vscnprintf(), thus avoid code duplication.
Signed-off-by: Anton Arapov <aarapov@redhat.com>
---
lib/vsprintf.c | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index c150d3d..85e6b27 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -1451,7 +1451,7 @@ EXPORT_SYMBOL(vsnprintf);
* @args: Arguments for the format string
*
* The return value is the number of characters which have been written into
- * the @buf not including the trailing '\0'. If @size is <= 0 the function
+ * the @buf not including the trailing '\0'. If @size is == 0 the function
* returns 0.
*
* Call this function if you are already dealing with a va_list.
@@ -1465,7 +1465,11 @@ int vscnprintf(char *buf, size_t size, const char *fmt, va_list args)
i = vsnprintf(buf, size, fmt, args);
- return (i >= size) ? (size - 1) : i;
+ if (likely(i < size))
+ return i;
+ if (size != 0)
+ return size - 1;
+ return 0;
}
EXPORT_SYMBOL(vscnprintf);
@@ -1513,14 +1517,10 @@ int scnprintf(char *buf, size_t size, const char *fmt, ...)
int i;
va_start(args, fmt);
- i = vsnprintf(buf, size, fmt, args);
+ i = vscnprintf(buf, size, fmt, args);
va_end(args);
- if (likely(i < size))
- return i;
- if (size != 0)
- return size - 1;
- return 0;
+ return i;
}
EXPORT_SYMBOL(scnprintf);
--
1.7.1
next reply other threads:[~2010-12-13 14:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 14:05 Anton Arapov [this message]
2010-12-13 14:25 ` Changli Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292249119-21600-1-git-send-email-aarapov@redhat.com \
--to=aarapov@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®