From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: gregkh@suse.de, linux-usb@vger.kernel.org,
dbrownell@users.sourceforge.net
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Rob Emanuele <rje@crystalfontz.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>
Subject: [PATCH v2] USB: atmel_usba_udc: fix freeing irq in usba_udc_remove()
Date: Tue, 14 Dec 2010 19:00:30 +0100 [thread overview]
Message-ID: <1292349630-3610-1-git-send-email-nicolas.ferre@atmel.com> (raw)
In-Reply-To: <636999.52551.qm@web180309.mail.gq1.yahoo.com>
From: Rob Emanuele <rje@crystalfontz.com>
Add a free_irq() call on vbus gpio when we remove udc so that the
vbus irq is properly released.
Signed-off-by: Rob Emanuele <rje@crystalfontz.com>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
David,
I modified $SUBJECT to be more explicit about which driver is modified.
Hope that makes sense now...
Bye,
drivers/usb/gadget/atmel_usba_udc.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c
index 717ff65..e7c65a4 100644
--- a/drivers/usb/gadget/atmel_usba_udc.c
+++ b/drivers/usb/gadget/atmel_usba_udc.c
@@ -2057,8 +2057,10 @@ static int __exit usba_udc_remove(struct platform_device *pdev)
usba_ep_cleanup_debugfs(&usba_ep[i]);
usba_cleanup_debugfs(udc);
- if (gpio_is_valid(udc->vbus_pin))
+ if (gpio_is_valid(udc->vbus_pin)) {
+ free_irq(gpio_to_irq(udc->vbus_pin), udc);
gpio_free(udc->vbus_pin);
+ }
free_irq(udc->irq, udc);
kfree(usba_ep);
--
1.7.3
next prev parent reply other threads:[~2010-12-14 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTimV2ENcWajrrMQ2Too4pf=XBfLczJ9HehNt4V_8@mail.gmail.com>
2010-12-14 15:05 ` [PATCH] AT91: usb gadget: fix freeing irq in _udc_remove() Nicolas Ferre
2010-12-14 16:21 ` David Brownell
2010-12-14 18:00 ` Nicolas Ferre [this message]
2010-12-15 1:29 ` [PATCH v2] USB: atmel_usba_udc: fix freeing irq in usba_udc_remove() Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292349630-3610-1-git-send-email-nicolas.ferre@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=dbrownell@users.sourceforge.net \
--cc=gregkh@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rje@crystalfontz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®