From: matthew@wil.cx
To: Greg KH <greg@kroah.com>
Cc: linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, Matthew Wilcox <matthew@wil.cx>,
Matthew Wilcox <willy@linux.intel.com>
Subject: [PATCH 5/5] uas: Use GFP_NOIO instead of GFP_KERNEL in I/O submission path
Date: Wed, 15 Dec 2010 15:44:06 -0500 [thread overview]
Message-ID: <1292445846-12101-5-git-send-email-matthew@wil.cx> (raw)
In-Reply-To: <20101215204147.GA1263@parisc-linux.org>
From: Matthew Wilcox <matthew@wil.cx>
If swap is on a UAS device, we could recurse into the driver by using
GFP_KERNEL. Using GFP_NOIO ensures we won't.
Reported-by: James Bottomley <James.Bottomley@suse.de>
Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
---
drivers/usb/storage/uas.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 0ebe7f6..23f0dd9 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/usb/storage/uas.c
@@ -141,7 +141,7 @@ static void uas_do_work(struct work_struct *work)
struct scsi_pointer *scp = (void *)cmdinfo;
struct scsi_cmnd *cmnd = container_of(scp,
struct scsi_cmnd, SCp);
- uas_submit_urbs(cmnd, cmnd->device->hostdata, GFP_KERNEL);
+ uas_submit_urbs(cmnd, cmnd->device->hostdata, GFP_NOIO);
}
}
--
1.7.2.3
prev parent reply other threads:[~2010-12-15 20:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 20:41 [PATCH 0/5] UAS updates Matthew Wilcox
2010-12-15 20:44 ` [PATCH 1/5] uas: Fix up the Sense IU matthew
2010-12-15 20:44 ` [PATCH 2/5] uas: Use kzalloc instead of kmalloc matthew
2010-12-15 20:44 ` [PATCH 3/5] uas: Rename sense pipe and sense urb to status pipe and status urb matthew
2010-12-15 20:44 ` [PATCH 4/5] uas: Ensure we only bind to a UAS interface matthew
2010-12-15 20:44 ` matthew [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292445846-12101-5-git-send-email-matthew@wil.cx \
--to=matthew@wil.cx \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®