From: Wolfram Sang <w.sang@pengutronix.de>
To: devicetree-discuss@ozlabs.org
Cc: linux-kernel@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>,
Wolfram Sang <w.sang@pengutronix.de>
Subject: [RFC 0/3] Introduce of_probe_platform_driver()
Date: Thu, 16 Dec 2010 18:13:56 +0100 [thread overview]
Message-ID: <1292519639-21859-1-git-send-email-w.sang@pengutronix.de> (raw)
First, I noted a section mismatch in the mpc52xx_psc_spi-driver which tried to
have its probe in __init. Then, I noted that the mpc512x_psc_spi-driver was in
the __devinit-section, not in __init. I finally saw that there is no
of-equivalent to platform_driver_probe() and tried to implement one.
This is the outcome which seems to work on a MPC5121-board. I have my
spi-device and the sysfs does not show bind/unbind-files.
I can't yet tell why, but the approach looks a bit clumsy. Probably there is
some condition I have missed so far. It should work as a first RFC, however.
Release early, right? :)
All the best,
Wolfram
Wolfram Sang (3):
of: platform: introduce of_probe_platform_driver()
spi: mpc52xx_psc_spi: fix section mismatch warning
spi: mpc512x_psc_spi: move init-routines to __init
drivers/of/platform.c | 30 +++++++++++++++++++++++++++---
drivers/spi/mpc512x_psc_spi.c | 10 +++++-----
drivers/spi/mpc52xx_psc_spi.c | 4 ++--
include/linux/of_platform.h | 2 ++
4 files changed, 36 insertions(+), 10 deletions(-)
--
1.7.2.3
next reply other threads:[~2010-12-16 17:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 17:13 Wolfram Sang [this message]
2010-12-16 17:13 ` [PATCH 1/3] of: platform: introduce of_probe_platform_driver() Wolfram Sang
2010-12-16 17:22 ` Grant Likely
2010-12-16 18:26 ` Wolfram Sang
2010-12-16 17:13 ` [PATCH 2/3] spi: mpc52xx_psc_spi: fix section mismatch warning Wolfram Sang
2010-12-16 17:23 ` Grant Likely
2010-12-16 17:13 ` [PATCH 3/3] spi: mpc512x_psc_spi: move probe-routine to __init Wolfram Sang
2010-12-16 17:27 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292519639-21859-1-git-send-email-w.sang@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=devicetree-discuss@ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®