From: Jean-Michel Hautbois <jhautbois@gmail.com>
To: davem@davemloft.net
Cc: richard.cochran@omicron.at, shemminger@vyatta.com, tj@kernel.org,
randy.dunlap@oracle.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jean-Michel Hautbois <jhautbois@gmail.com>
Subject: [PATCH 2/4] net: phy: printk issues fixed
Date: Sun, 19 Dec 2010 11:58:49 +0100 [thread overview]
Message-ID: <1292756331-3735-2-git-send-email-jhautbois@gmail.com> (raw)
In-Reply-To: <1292756331-3735-1-git-send-email-jhautbois@gmail.com>
When calling net link change, pr_info and printk where interleaved.
Changed the way to print messages.
Signed-off-by: Jean-Michel Hautbois <jhautbois@gmail.com>
---
drivers/net/phy/phy.c | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 5f23e8e..4ab48d7 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -44,14 +44,14 @@
*/
void phy_print_status(struct phy_device *phydev)
{
- pr_info("PHY: %s - Link is %s", dev_name(&phydev->dev),
- phydev->link ? "Up" : "Down");
if (phydev->link)
- printk(" - %d/%s", phydev->speed,
- DUPLEX_FULL == phydev->duplex ?
- "Full" : "Half");
-
- printk("\n");
+ pr_info("PHY: %s - Link is up - %d/%s\n",
+ dev_name(&phydev->dev),
+ phydev->speed,
+ phydev->duplex == DUPLEX_FULL ? "Full" : "Half");
+ else
+ pr_info("PHY: %s - Link is down\n",
+ dev_name(&phydev->dev));
}
EXPORT_SYMBOL(phy_print_status);
--
1.7.0.4
next prev parent reply other threads:[~2010-12-19 10:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-19 10:58 [PATCH 1/4] net: phy: balance disable/enable irq on change Jean-Michel Hautbois
2010-12-19 10:58 ` Jean-Michel Hautbois [this message]
2010-12-19 10:58 ` [PATCH 3/4] net: phy: White space correction and switch/case braces Jean-Michel Hautbois
2010-12-19 10:58 ` [PATCH 4/4] net: phy: EXPORT_SYMBOL not following the function Jean-Michel Hautbois
2010-12-23 19:24 ` [PATCH 1/4] net: phy: balance disable/enable irq on change David Miller
2010-12-24 8:46 ` Jean-Michel Hautbois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292756331-3735-2-git-send-email-jhautbois@gmail.com \
--to=jhautbois@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=richard.cochran@omicron.at \
--cc=shemminger@vyatta.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®