From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Ken Mills <ken.k.mills@intel.com>,
Alan Cox <alan@linux.intel.com>,
stable@kernel.org, Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 2/2] n_gsm: gsm_data_alloc buffer allocation could fail and it is not being checked
Date: Mon, 20 Dec 2010 20:58:37 -0800 [thread overview]
Message-ID: <1292907517-12275-2-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <20101221044205.GB11750@kroah.com>
From: Ken Mills <ken.k.mills@intel.com>
gsm_data_alloc buffer allocation could fail and it is not being checked.
Add check for allocated buffer and return if the buffer allocation
fails.
Signed-off-by: Ken Mills <ken.k.mills@intel.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/tty/n_gsm.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 2fc5cf2..c5f8e5b 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -968,6 +968,8 @@ static void gsm_control_reply(struct gsm_mux *gsm, int cmd, u8 *data,
{
struct gsm_msg *msg;
msg = gsm_data_alloc(gsm, 0, dlen + 2, gsm->ftype);
+ if (msg == NULL)
+ return;
msg->data[0] = (cmd & 0xFE) << 1 | EA; /* Clear C/R */
msg->data[1] = (dlen << 1) | EA;
memcpy(msg->data + 2, data, dlen);
--
1.7.3.2
next prev parent reply other threads:[~2010-12-21 4:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 4:42 [GIT PATCH] TTY/serial fixes for .37-rc6 Greg KH
2010-12-21 4:58 ` [PATCH 1/2] n_gsm: Fix message length handling when building header Greg Kroah-Hartman
2010-12-21 4:58 ` Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-12-13 15:27 Alan Cox
2010-12-13 15:28 ` [PATCH 2/2] n_gsm: gsm_data_alloc buffer allocation could fail and it is not being checked Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292907517-12275-2-git-send-email-gregkh@suse.de \
--to=gregkh@suse.de \
--cc=alan@linux.intel.com \
--cc=ken.k.mills@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome