From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751800AbdJDBHX (ORCPT ); Tue, 3 Oct 2017 21:07:23 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:30337 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751731AbdJDBHW (ORCPT ); Tue, 3 Oct 2017 21:07:22 -0400 Subject: Re: [PATCH net] RDS: IB: Initialize max_items based on underlying device attributes To: Avinash Repaka , linux-rdma@vger.kernel.org References: <1507078237-32366-1-git-send-email-avinash.repaka@oracle.com> From: Santosh Shilimkar Organization: Oracle Corporation Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <1292cf1e-bbc7-9ee6-aafc-29d2e5c8befb@oracle.com> Date: Tue, 3 Oct 2017 18:07:59 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1507078237-32366-1-git-send-email-avinash.repaka@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Avinash, On 10/3/2017 5:50 PM, Avinash Repaka wrote: > Use max_1m_mrs/max_8k_mrs while setting max_items, as the former > variables are set based on the underlying device attricutes. > s/attricutes/attributes > Signed-off-by: Avinash Repaka > --- > net/rds/ib_rdma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > This patch is fine but it will be nice if you can collect these changes in series as you are trying to update the FRWR support. Like this patch and other cleanup patch you posted yesterday. With that log fixed, Acked-by: Santosh Shilimkar