mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suresh Siddha <suresh.b.siddha@intel.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Borislav Petkov <bp@alien8.de>,
	Nigel Cunningham <lkml@nigelcunningham.com.au>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [patch] x86: avoid unnecessary smp alternatives switch during suspend/resume
Date: Mon, 03 Jan 2011 15:44:13 -0800	[thread overview]
Message-ID: <1294098253.2680.57.camel@sbsiddha-MOBL3.sc.intel.com> (raw)
In-Reply-To: <20110102091142.GA32469@atrey.karlin.mff.cuni.cz>

On Sun, 2011-01-02 at 01:11 -0800, Pavel Machek wrote:
> Hi!
> 
> > > We have a few others things that want to modify their behaviour
> > > according to whether we're doing the atomic copy/restore. Perhaps it
> > > would be an idea to just use a single flag, perhaps a value for
> > > system_state?
> > 
> > I agree, it would be nicer if we don't introduce a special flag
> > just for that. Other than that, I like all sane code that speeds up
> > suspend/resume :). I've attached before/after dmesg excerpts on my
> > system with the patch ontop of v2.6.37-rc2-181-gb86db47. We end up
> > saving 11601 ??secs according to CONFIG_PRINTK_TIME but hey, the code is
> > simple enough :).
> 
> 11msec is not worth the uglyness of global variable like this. Should
> we get a parameter, or something?

Pavel, Latest patch (that is now in -tip) moved the global variable to
the x86 code.

http://marc.info/?l=linux-kernel&m=129236179019935&w=2

thanks,
suresh


  reply	other threads:[~2011-01-03 23:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-20  0:09 Suresh Siddha
2010-11-20 16:31 ` Ben Gamari
2010-11-21  6:02 ` Américo Wang
2010-11-21  9:27 ` Nigel Cunningham
2010-11-21 10:03   ` Borislav Petkov
2011-01-02  9:11     ` Pavel Machek
2011-01-03 23:44       ` Suresh Siddha [this message]
2010-11-22  2:30   ` H. Peter Anvin
2010-11-24  0:11   ` Suresh Siddha
2010-12-14 21:21     ` [tip:x86/alternatives] x86, suspend: Avoid " tip-bot for Suresh Siddha
2010-12-14 22:31       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294098253.2680.57.camel@sbsiddha-MOBL3.sc.intel.com \
    --to=suresh.b.siddha@intel.com \
    --cc=arjan@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@nigelcunningham.com.au \
    --cc=mingo@elte.hu \
    --cc=pavel@ucw.cz \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®