From: Don Zickus <dzickus@redhat.com>
To: x86@kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Don Zickus <dzickus@redhat.com>, Jan Kiszka <jan.kiszka@web.de>
Subject: [PATCH 1/3] x86: Only call smp_processor_id in non-preempt cases
Date: Tue, 4 Jan 2011 22:38:07 -0500 [thread overview]
Message-ID: <1294198689-15447-1-git-send-email-dzickus@redhat.com> (raw)
There are some paths that walk the die_chain with preemption on.
Make sure we are in an NMI call before we start doing anything.
This was triggered by do_general_protection calling notify_die with
DIE_GPF.
Reported-by: Jan Kiszka <jan.kiszka@web.de>
CC: Jan Kiszka <jan.kiszka@web.de>
Signed-off-by: Don Zickus <dzickus@redhat.com>
---
arch/x86/kernel/apic/hw_nmi.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/apic/hw_nmi.c b/arch/x86/kernel/apic/hw_nmi.c
index c57d0b5..2b40a60 100644
--- a/arch/x86/kernel/apic/hw_nmi.c
+++ b/arch/x86/kernel/apic/hw_nmi.c
@@ -51,7 +51,7 @@ arch_trigger_all_cpu_backtrace_handler(struct notifier_block *self,
{
struct die_args *args = __args;
struct pt_regs *regs;
- int cpu = smp_processor_id();
+ int cpu;
switch (cmd) {
case DIE_NMI:
@@ -63,6 +63,7 @@ arch_trigger_all_cpu_backtrace_handler(struct notifier_block *self,
}
regs = args->regs;
+ cpu = smp_processor_id();
if (cpumask_test_cpu(cpu, to_cpumask(backtrace_mask))) {
static arch_spinlock_t lock = __ARCH_SPIN_LOCK_UNLOCKED;
--
1.7.3.4
next reply other threads:[~2011-01-05 3:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 3:38 Don Zickus [this message]
2011-01-05 3:38 ` [PATCH 2/3] x86: Avoid calling arch_trigger_all_cpu_backtrace() at the same time Don Zickus
2011-01-05 14:07 ` [tip:perf/core] " tip-bot for Dongdong Deng
2011-01-05 3:38 ` [PATCH 3/3] x86, NMI: Add touch_nmi_watchdog to io_check_error delay Don Zickus
2011-01-05 14:08 ` [tip:perf/core] " tip-bot for Huang Ying
2011-01-05 14:07 ` [tip:perf/core] x86: Only call smp_processor_id in non-preempt cases tip-bot for Don Zickus
-- strict thread matches above, loose matches on Subject: below --
2010-11-12 14:50 [PATCH 1/3] x86: only " Don Zickus
2010-11-18 8:14 ` Ingo Molnar
2010-11-18 14:22 ` Don Zickus
2010-11-18 14:49 ` Ingo Molnar
2010-11-18 15:35 ` Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294198689-15447-1-git-send-email-dzickus@redhat.com \
--to=dzickus@redhat.com \
--cc=jan.kiszka@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®