From: Don Zickus <dzickus@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: akpm@linux-foundation.org, fweisbec@gmail.com,
LKML <linux-kernel@vger.kernel.org>,
Don Zickus <dzickus@redhat.com>
Subject: [PATCH 1/2] panic: ratelimit panic messages
Date: Tue, 4 Jan 2011 22:38:30 -0500 [thread overview]
Message-ID: <1294198711-15492-2-git-send-email-dzickus@redhat.com> (raw)
In-Reply-To: <1294198711-15492-1-git-send-email-dzickus@redhat.com>
Sometimes when things go bad, so much spew is coming on the console it is hard
to figure out what happened. This patch allows you to ratelimit the panic
messages with the intent that the first panic message will provide the info
we need to figure out what happened.
Adds new kernel param 'panic_ratelimit=on/<integer in seconds>'
Signed-off-by: Don Zickus <dzickus@redhat.com>
---
Documentation/kernel-parameters.txt | 6 ++++++
kernel/panic.c | 30 ++++++++++++++++++++++++++++++
2 files changed, 36 insertions(+), 0 deletions(-)
diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
index 316c723..1416964 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -1807,6 +1807,12 @@ and is between 256 and 4096 characters. It is defined in the file
panic= [KNL] Kernel behaviour on panic
Format: <timeout>
+ panic_ratelimit= [KNL] ratelimit the panic messages
+ Useful for slowing down multiple panics to capture
+ the first one before it scrolls off the screen
+ Format: "on" or some integer in seconds
+ "on" defaults to 10 minutes
+
parkbd.port= [HW] Parallel port number the keyboard adapter is
connected to, default is 0.
Format: <parport#>
diff --git a/kernel/panic.c b/kernel/panic.c
index 4c13b1a..fe89e04 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -23,6 +23,7 @@
#include <linux/init.h>
#include <linux/nmi.h>
#include <linux/dmi.h>
+#include <linux/ratelimit.h>
#define PANIC_TIMER_STEP 100
#define PANIC_BLINK_SPD 18
@@ -48,6 +49,31 @@ static long no_blink(int state)
long (*panic_blink)(int state);
EXPORT_SYMBOL(panic_blink);
+/* setting default to 0 effectively disables it */
+DEFINE_RATELIMIT_STATE(panic_ratelimit_state, 0, 1);
+
+static int __init panic_ratelimit_setup(char *str)
+{
+ int interval;
+
+ if (!strncmp(str, "on", 2))
+ /* default to 10 minutes */
+ interval = 600 * HZ;
+ else
+ interval = simple_strtoul(str, NULL, 0) * HZ;
+
+ panic_ratelimit_state.interval = interval;
+ return 1;
+}
+__setup("panic_ratelimit=", panic_ratelimit_setup);
+
+static int __panic_ratelimit(const char *func)
+{
+ return ___ratelimit(&panic_ratelimit_state, func);
+}
+
+#define panic_ratelimit() __panic_ratelimit(__func__)
+
/**
* panic - halt the system
* @fmt: The text string to print
@@ -63,6 +89,10 @@ NORET_TYPE void panic(const char * fmt, ...)
long i, i_next = 0;
int state = 0;
+ if (!panic_ratelimit())
+ for(;;)
+ cpu_relax();
+
/*
* It's possible to come here directly from a panic-assertion and
* not have preempt disabled. Some functions called from here want
--
1.7.3.4
next prev parent reply other threads:[~2011-01-05 3:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 3:38 [PATCH 0/2] touch_nmi_watchdog semantic changes Don Zickus
2011-01-05 3:38 ` Don Zickus [this message]
2011-01-05 13:21 ` [PATCH 1/2] panic: ratelimit panic messages Ingo Molnar
2011-01-05 14:00 ` Don Zickus
2011-01-05 22:51 ` Andrew Morton
2011-01-06 2:05 ` Don Zickus
2011-01-06 2:16 ` Andrew Morton
2011-01-15 8:29 ` Dave Young
2011-01-15 11:03 ` Dave Young
2011-01-05 3:38 ` [PATCH 2/2] watchdog: touch_nmi_watchdog should only touch local cpu not every one Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294198711-15492-2-git-send-email-dzickus@redhat.com \
--to=dzickus@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®