From: John Stultz <john.stultz@linaro.org>
To: linux-kernel@vger.kernel.org
Cc: John Stultz <john.stultz@linaro.org>
Subject: [PATCH 11/12] timers: Add rb_init_node() to allow for stack allocated rb nodes
Date: Wed, 5 Jan 2011 18:15:58 -0800 [thread overview]
Message-ID: <1294280159-2513-12-git-send-email-john.stultz@linaro.org> (raw)
In-Reply-To: <1294280159-2513-1-git-send-email-john.stultz@linaro.org>
In cases where a timerqueue_node or some structure that utilizes
a timerqueue_node is allocated on the stack, gcc would give warnings
caused by the timerqueue_init()'s calling RB_CLEAR_NODE, which
self-references the nodes uninitialized data.
The solution is to create an rb_init_node() function that zeros
the rb_node structure out and then calls RB_CLEAR_NODE(), and
then call the new init function from timerqueue_init().
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
include/linux/rbtree.h | 8 ++++++++
include/linux/timerqueue.h | 2 +-
2 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/include/linux/rbtree.h b/include/linux/rbtree.h
index 7066acb..033b507 100644
--- a/include/linux/rbtree.h
+++ b/include/linux/rbtree.h
@@ -136,6 +136,14 @@ static inline void rb_set_color(struct rb_node *rb, int color)
#define RB_EMPTY_NODE(node) (rb_parent(node) == node)
#define RB_CLEAR_NODE(node) (rb_set_parent(node, node))
+static inline void rb_init_node(struct rb_node *rb)
+{
+ rb->rb_parent_color = 0;
+ rb->rb_right = NULL;
+ rb->rb_left = NULL;
+ RB_CLEAR_NODE(rb);
+}
+
extern void rb_insert_color(struct rb_node *, struct rb_root *);
extern void rb_erase(struct rb_node *, struct rb_root *);
diff --git a/include/linux/timerqueue.h b/include/linux/timerqueue.h
index 406b103..67cca3d 100644
--- a/include/linux/timerqueue.h
+++ b/include/linux/timerqueue.h
@@ -26,7 +26,7 @@ extern struct timerqueue_node *timerqueue_iterate_next(
static inline void timerqueue_init(struct timerqueue_node *node)
{
- RB_CLEAR_NODE(&node->node);
+ rb_init_node(&node->node);
}
static inline void timerqueue_init_head(struct timerqueue_head *head)
--
1.7.3.2.146.gca209
next prev parent reply other threads:[~2011-01-06 2:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 2:15 [PATCH 00/12] Posix Alarm Timers full patchset John Stultz
2011-01-06 2:15 ` [PATCH 01/12] timers: Introduce timerlist infrastructure John Stultz
2011-01-06 2:15 ` [PATCH 02/12] timers: Rename timerlist infrastructure to timerqueue John Stultz
2011-01-06 2:15 ` [PATCH 03/12] timers: Fixup allmodconfig build issue John Stultz
2011-01-06 2:15 ` [PATCH 04/12] hrtimers: Convert hrtimers to use timerlist infrastructure John Stultz
2011-01-06 2:15 ` [PATCH 05/12] hrtimer: fix timerqueue conversion flub John Stultz
2011-01-06 2:15 ` [PATCH 06/12] RTC: Rework RTC code to use timerqueue for events John Stultz
2011-01-06 2:15 ` [PATCH 07/12] RTC: Remove UIE emulation John Stultz
2011-01-06 2:15 ` [PATCH 08/12] rtc: Namespace fixup John Stultz
2011-01-06 2:15 ` [PATCH 09/12] [RFC] hrtimers: extend hrtimer base code to handle more then 2 clockids John Stultz
2011-01-06 2:15 ` [PATCH 10/12] [RFC] hrtimers: Add CLOCK_BOOTTIME clockid, hrtimerbase and posix interface John Stultz
2011-01-06 2:15 ` John Stultz [this message]
2011-01-06 2:15 ` [PATCH 12/12] [RFC] Introduce Alarm (hybrid) timers John Stultz
2011-01-06 4:07 ` Arve Hjønnevåg
2011-01-06 18:04 ` John Stultz
2011-01-07 0:58 ` Arve Hjønnevåg
2011-01-07 2:30 ` John Stultz
2011-01-08 10:36 ` Rafael J. Wysocki
2011-01-13 5:03 ` Arve Hjønnevåg
2011-01-11 18:56 ` John Stultz
2011-01-11 19:22 ` Anca Emanuel
2011-01-13 4:50 ` Arve Hjønnevåg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294280159-2513-12-git-send-email-john.stultz@linaro.org \
--to=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®