From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756069Ab1AGDEy (ORCPT ); Thu, 6 Jan 2011 22:04:54 -0500 Received: from mail-wy0-f174.google.com ([74.125.82.174]:37929 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756018Ab1AGDEv (ORCPT ); Thu, 6 Jan 2011 22:04:51 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=OYyiFgNC3+2cMkf2I7LCyCceRyXbw4ELIWKxD1CopsZlDiwVZhcb8XJ3RIKIGoly6Y lvMXmGHMO/Ub26qDSV8GkEHomlfutBfwejq7MV4Ro3DAVwY7E21JsjQE4Ppqu7zJYGmC fzR3HYL4WF6R07057ool7sxjFuw+meQ8hIMCE= Subject: Re: [PATCH 2.6.36] vlan: Avoid hwaccel vlan packets when vid not used From: Eric Dumazet To: Matt Carlson Cc: Jesse Gross , Michael Leun , Michael Chan , David Miller , Ben Greear , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" In-Reply-To: <20110107025930.GA17808@mcarlson.broadcom.com> References: <20101214191500.GD19951@mcarlson.broadcom.com> <1293901393.2535.49.camel@edumazet-laptop> <1293984348.2535.101.camel@edumazet-laptop> <1294356887.2704.13.camel@edumazet-laptop> <1294363201.2704.19.camel@edumazet-laptop> <20110107022912.GA17757@mcarlson.broadcom.com> <1294368071.2704.49.camel@edumazet-laptop> <1294368202.2704.50.camel@edumazet-laptop> <20110107025930.GA17808@mcarlson.broadcom.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 07 Jan 2011 04:04:46 +0100 Message-ID: <1294369486.2704.53.camel@edumazet-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le jeudi 06 janvier 2011 à 18:59 -0800, Matt Carlson a écrit : > On Thu, Jan 06, 2011 at 06:43:22PM -0800, Eric Dumazet wrote: > > Le vendredi 07 janvier 2011 ?? 03:41 +0100, Eric Dumazet a ??crit : > > > Le jeudi 06 janvier 2011 ?? 18:29 -0800, Matt Carlson a ??crit : > > > > > > > Hi Eric. Sorry for the delay. I was under the impression that your > > > > problems were software related and that you just needed a revised > > > > version of these VLAN patches I was sending to Michael. Is this not > > > > true? > > > > > > > > Having a hardware stat increment suggests this is a new problem. > > > > Maybe I missed it, but I didn't see what hardware you are working > > > > with and whether or not management firmware was enabled. Could you tell > > > > me that info? > > > > > > > > > > Hi Matt > > > > > > I started a bisection, because I couldnt sleep tonight anyway :( > > > > > > 14:04.0 Ethernet controller: Broadcom Corporation NetXtreme BCM5715S > > > Gigabit Ethernet (rev a3) > > > Subsystem: Hewlett-Packard Company NC326m PCIe Dual Port Adapter > > > Flags: bus master, 66MHz, medium devsel, latency 64, IRQ 43 > > > Memory at fdff0000 (64-bit, non-prefetchable) [size=64K] > > > Memory at fdfe0000 (64-bit, non-prefetchable) [size=64K] > > > [virtual] Expansion ROM at fdbe0000 [disabled] [size=128K] > > > Capabilities: [40] PCI-X non-bridge device > > > Capabilities: [48] Power Management version 2 > > > Capabilities: [50] Vital Product Data > > > Capabilities: [58] MSI: Enable+ Count=1/8 Maskable- 64bit+ > > > Kernel driver in use: tg3 > > > Kernel modules: tg3 > > > > > > > > > > $ ethtool -i eth2 > > driver: tg3 > > version: 3.115 > > firmware-version: 5715s-v3.28 > > bus-info: 0000:14:04.0 > > $ dmesg | grep ASF > > [ 6.220577] tg3 0000:14:04.0: eth2: RXcsums[1] LinkChgREG[0] MIirq[0] > > ASF[0] TSOcap[1] > > [ 6.228586] tg3 0000:14:04.1: eth3: RXcsums[1] LinkChgREG[0] MIirq[0] > > ASF[0] TSOcap[1] > > Thanks. So management firmware is disabled. This should be > straightforward case. > > I'm wondering if I'm misunderstanding something though. You said earlier > that VLAN tagging doesn't work unless you applied my patch. Is this no > longer true? > I dont apply your patch because Jesse said it was not a good patch ;) Maybe I missed something and it must be applied ? Problem is : current Linus tree now includes net-next-2.6 and vlan doesnt work. You should resubmit it perhaps ?