From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753208Ab1AHCVU (ORCPT ); Fri, 7 Jan 2011 21:21:20 -0500 Received: from mga02.intel.com ([134.134.136.20]:21553 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752614Ab1AHCVM (ORCPT ); Fri, 7 Jan 2011 21:21:12 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.60,292,1291622400"; d="scan'208";a="694751178" From: Youquan Song To: linux-kernel@vger.kernel.org, hpa@linux.intel.com, suresh.b.siddha@intel.com Cc: yong.y.wang@linux.intel.com, joe@perches.com, jbaron@redhat.com, arjan@linux.intel.com, trenn@suse.de, kent.liu@intel.com, chaohong.guo@intel.com, Youquan Song , Youquan Song Subject: [PATCH v3 2/2] apic: Add print error interrupt reason Date: Sat, 8 Jan 2011 10:20:11 +0800 Message-Id: <1294453211-26439-3-git-send-email-youquan.song@intel.com> X-Mailer: git-send-email 1.6.4.2 In-Reply-To: <1294453211-26439-2-git-send-email-youquan.song@intel.com> References: <1294453211-26439-1-git-send-email-youquan.song@intel.com> <1294453211-26439-2-git-send-email-youquan.song@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org End user worry about the error interrupt information and intend to know what kind of error interrupts are generated, so this patch add printing out the detail debug information of error interrupt. dynamic debug is not initiated when LAPIC initiation, so the pr_debug will not output the error interrupt debug information when boot. In this patch, we use apic_printk(APIC_DEBUG,), so if add kernel option apic=debug will output the error interrupt during boot. Signed-off-by: Youquan Song --- arch/x86/kernel/apic/apic.c | 29 ++++++++++++++++++++++++++++- 1 files changed, 28 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index 3f838d5..f0f2809 100644 --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -1794,6 +1794,32 @@ void smp_spurious_interrupt(struct pt_regs *regs) irq_exit(); } +static const char * const error_interrupt_reason[] = { + "Send CS error", + "Receive CS error", + "Send accept error", + "Receive accept error", + "Redirectable IPI", + "Send illegal vector", + "Received illegal vector", + "Illegal register address", +}; + +static void print_error_interrupt_reason(u32 reason) +{ + u32 i = 0; + reason = reason & 0xff; + do { + if (reason & 0x1) + apic_printk(APIC_DEBUG, " : %s", + error_interrupt_reason[i]); + i++; + reason >>= 1; + } while (reason > 0); + + apic_printk(APIC_DEBUG, "\n"); +} + /* * This interrupt should never happen with our APIC/SMP architecture */ @@ -1821,8 +1847,9 @@ void smp_error_interrupt(struct pt_regs *regs) * 6: Received illegal vector * 7: Illegal register address */ - pr_debug("APIC error on CPU%d: %02x(%02x)\n", + apic_printk(APIC_DEBUG, "APIC error on CPU%d: %02x(%02x)", smp_processor_id(), v , v1); + print_error_interrupt_reason(v1); irq_exit(); } -- 1.6.4.2