From: Youquan Song <youquan.song@intel.com>
To: linux-kernel@vger.kernel.org, hpa@linux.intel.com,
suresh.b.siddha@intel.com
Cc: yong.y.wang@linux.intel.com, joe@perches.com, jbaron@redhat.com,
arjan@linux.intel.com, trenn@suse.de, kent.liu@intel.com,
chaohong.guo@intel.com,
Youquan Song <youquan.song@linux.intel.com>,
Youquan Song <youquan.song@intel.com>
Subject: [PATCH v4 2/2] apic: Add print error interrupt reason
Date: Sun, 9 Jan 2011 00:01:17 +0800 [thread overview]
Message-ID: <1294502477-28280-1-git-send-email-youquan.song@intel.com> (raw)
End user worry about the error interrupt information and intend to know what
kind of error interrupts are generated, so this patch add printing out the
detail debug information of error interrupt.
dynamic debug is not initiated when LAPIC initiation, so the pr_debug will not
output the error interrupt debug information when boot.
In this patch, we use apic_printk(APIC_DEBUG,), so if add kernel option
apic=debug will output the error interrupt during boot.
Thanks for help from Joe Perches <joe@perches.com> about printk format.
Signed-off-by: Youquan Song <youquan.song@intel.com>
---
arch/x86/kernel/apic/apic.c | 38 +++++++++++++++++++++++++-------------
1 files changed, 25 insertions(+), 13 deletions(-)
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 3f838d5..5ed54cd 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -1800,6 +1800,17 @@ void smp_spurious_interrupt(struct pt_regs *regs)
void smp_error_interrupt(struct pt_regs *regs)
{
u32 v, v1;
+ u32 i = 0;
+ static const char * const error_interrupt_reason[] = {
+ "Send CS error", /* APIC Error Bit 0 */
+ "Receive CS error", /* APIC Error Bit 1 */
+ "Send accept error", /* APIC Error Bit 2 */
+ "Receive accept error", /* APIC Error Bit 3 */
+ "Redirectable IPI", /* APIC Error Bit 4 */
+ "Send illegal vector", /* APIC Error Bit 5 */
+ "Received illegal vector", /* APIC Error Bit 6 */
+ "Illegal register address", /* APIC Error Bit 7 */
+ };
exit_idle();
irq_enter();
@@ -1810,19 +1821,20 @@ void smp_error_interrupt(struct pt_regs *regs)
ack_APIC_irq();
atomic_inc(&irq_err_count);
- /*
- * Here is what the APIC error bits mean:
- * 0: Send CS error
- * 1: Receive CS error
- * 2: Send accept error
- * 3: Receive accept error
- * 4: Reserved
- * 5: Send illegal vector
- * 6: Received illegal vector
- * 7: Illegal register address
- */
- pr_debug("APIC error on CPU%d: %02x(%02x)\n",
- smp_processor_id(), v , v1);
+ apic_printk(APIC_DEBUG, KERN_DEBUG "APIC error on CPU%d: %02x(%02x)",
+ smp_processor_id(), v , v1);
+
+ v1 = v1 & 0xff;
+ while (v1) {
+ if (v1 & 0x1)
+ apic_printk(APIC_DEBUG, KERN_CONT " : %s",
+ error_interrupt_reason[i]);
+ i++;
+ v1 >>= 1;
+ };
+
+ apic_printk(APIC_DEBUG, KERN_CONT "\n");
+
irq_exit();
}
--
1.6.4.2
next reply other threads:[~2011-01-08 16:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-08 16:01 Youquan Song [this message]
2011-04-06 12:20 [PATCH v4 1/2] apic: Fix error interrupt report at all APs Youquan Song
2011-04-06 12:20 ` [PATCH v4 2/2] apic: Add print error interrupt reason Youquan Song
2011-04-14 6:36 [PATCH v4 1/2] apic: Fix error interrupt report at all APs Youquan Song
2011-04-14 6:36 ` [PATCH v4 2/2] apic: Add print error interrupt reason Youquan Song
2011-04-14 7:54 ` Cyrill Gorcunov
2011-04-14 7:57 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294502477-28280-1-git-send-email-youquan.song@intel.com \
--to=youquan.song@intel.com \
--cc=arjan@linux.intel.com \
--cc=chaohong.guo@intel.com \
--cc=hpa@linux.intel.com \
--cc=jbaron@redhat.com \
--cc=joe@perches.com \
--cc=kent.liu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=trenn@suse.de \
--cc=yong.y.wang@linux.intel.com \
--cc=youquan.song@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®