From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Michael Ellerman <michael@ellerman.id.au>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 4/4] driver core: Document that device_rename() is only for networking
Date: Mon, 10 Jan 2011 16:23:25 -0800 [thread overview]
Message-ID: <1294705405-31471-4-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <20110110234825.GA30018@kroah.com>
From: Michael Ellerman <michael@ellerman.id.au>
Document that device_rename() is not to be used by anything
other than the network core.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/base/core.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index 46ff6c2..610d967 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -1513,6 +1513,8 @@ EXPORT_SYMBOL_GPL(device_destroy);
* exclusion between two different calls of device_rename
* on the same device to ensure that new_name is valid and
* won't conflict with other devices.
+ *
+ * "Never use this function, bad things will happen" - gregkh
*/
int device_rename(struct device *dev, const char *new_name)
{
--
1.7.3.2
prev parent reply other threads:[~2011-01-11 0:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 23:48 [GIT PATCH] driver core patches for .38 Greg KH
2011-01-11 0:23 ` [PATCH 1/4] driver core: fix whitespace in class_attr_string Greg Kroah-Hartman
2011-01-11 0:23 ` [PATCH 2/4] driver-core: merge private parts of class and bus Greg Kroah-Hartman
2011-01-11 0:23 ` [PATCH 3/4] sysfs: remove useless test from sysfs_merge_group Greg Kroah-Hartman
2011-01-11 0:23 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294705405-31471-4-git-send-email-gregkh@suse.de \
--to=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®