From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, hong.xu@atmel.com,
Nicolas Ferre <nicolas.ferre@atmel.com>
Subject: [PATCH 3/6] dmaengine: at_hdmac: no need set ACK in new descriptor
Date: Wed, 12 Jan 2011 15:39:07 +0100 [thread overview]
Message-ID: <1294843150-6962-2-git-send-email-nicolas.ferre@atmel.com> (raw)
In-Reply-To: <1292435416-16927-1-git-send-email-nicolas.ferre@atmel.com>
Following descriptor flow in at_hdmac driver, descriptor comming from
atc_desc_get() as already DMA_CTRL_ACK flag set. No need to set it again.
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
drivers/dma/at_hdmac.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
index a4dd4bc..4f83431 100644
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -583,7 +583,6 @@ atc_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest, dma_addr_t src,
desc->lli.ctrlb = ctrlb;
desc->txd.cookie = 0;
- async_tx_ack(&desc->txd);
if (!first) {
first = desc;
--
1.7.3
next prev parent reply other threads:[~2011-01-12 13:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 17:50 [PATCH] dmaengine: at_hdmac: use dma_address to program DMA hardware Nicolas Ferre
2011-01-10 13:21 ` Nicolas Ferre
2011-01-15 0:14 ` Dan Williams
2011-01-12 14:39 ` [PATCH 2/6] dmaengine: at_hdmac: trivial add precision to unmapping comment Nicolas Ferre
2011-01-12 14:39 ` Nicolas Ferre [this message]
2011-01-12 14:39 ` [PATCH 4/6] dmaengine: at_hdmac: use subsys_initcall instead of module_init Nicolas Ferre
2011-01-15 0:27 ` Dan Williams
2011-01-12 14:39 ` [PATCH 5/6] dmaengine: at_hdmac: flags located in first descriptor Nicolas Ferre
2011-01-12 14:39 ` [PATCH 6/6] dmaengine: at_hdmac: fix race while monitoring channel status Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294843150-6962-2-git-send-email-nicolas.ferre@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=dan.j.williams@intel.com \
--cc=hong.xu@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®