From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756777Ab1AMStI (ORCPT ); Thu, 13 Jan 2011 13:49:08 -0500 Received: from mail-yx0-f174.google.com ([209.85.213.174]:43630 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751835Ab1AMStE (ORCPT ); Thu, 13 Jan 2011 13:49:04 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=cyAQQZvlQQj6t/jMl6pEAjBuKmQ7G1Sg9x5uImUHactO+fS/nRgMlwQpgxzgStZH+D vQbTcRnL5uaL1k22svJLc4YdRxy/vs5z18Sfv9lm4NmyQDNy7auEJVvi36n6LDI0FHZU jHs+e3vv7Ax5kQxf08xcWAsitwYPV9mGRZ72c= From: yangsheng To: linux-scsi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, yangsheng Subject: [PATCH] Set error value while device_add() failed. Date: Fri, 14 Jan 2011 02:48:43 +0800 Message-Id: <1294944523-6546-1-git-send-email-sickamd@gmail.com> X-Mailer: git-send-email 1.7.2.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: yangsheng --- drivers/scsi/sd.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index d21dd17..2ca5250 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -2474,7 +2474,8 @@ static int sd_probe(struct device *dev) sdkp->dev.class = &sd_disk_class; dev_set_name(&sdkp->dev, dev_name(dev)); - if (device_add(&sdkp->dev)) + error = device_add(&sdkp->dev); + if (error) goto out_free_index; get_device(dev); -- 1.7.2.3