mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wilfred Mallawa <wilfred.opensource@gmail.com>
To: Damien Le Moal <dlemoal@kernel.org>,
	bhelgaas@google.com,  mika.westerberg@linux.intel.com,
	sathyanarayanan.kuppuswamy@linux.intel.com, 	lukas@wunner.de
Cc: alistair.francis@wdc.com, linux-pci@vger.kernel.org,
	 linux-kernel@vger.kernel.org, cassel@kernel.org
Subject: Re: [PATCH] PCI: fix the printed delay amount in info print
Date: Mon, 14 Apr 2025 10:18:13 +1000	[thread overview]
Message-ID: <1294b288226cba1f9bc63956720be9c0b2ac6117.camel@gmail.com> (raw)
In-Reply-To: <f56d8794-07a1-4040-8743-0599fb488dba@kernel.org>

On Sun, 2025-04-13 at 14:17 +0900, Damien Le Moal wrote:
> On 4/12/25 15:09, Wilfred Mallawa wrote:
> > From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
> > 
> > Print the delay amount that pcie_wait_for_link_delay() is invoked
> > with
> > instead of the hardcoded 1000ms value in the debug info print.
> > 
> > Fixes: 7b3ba09febf4 ("PCI/PM: Shorten
> > pci_bridge_wait_for_secondary_bus() wait
> > time for slow links")
> > 
> 
> Please remove the blank line here and do not wrap the Fixes tag line.
> With that fixed, looks OK to me. So feel free to add:
> 
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Thanks! fixed in V2.

Wilfred
> 
> > Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
> > ---
> >  drivers/pci/pci.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> > index 869d204a70a3..8139b70cafa9 100644
> > --- a/drivers/pci/pci.c
> > +++ b/drivers/pci/pci.c
> > @@ -4935,7 +4935,7 @@ int pci_bridge_wait_for_secondary_bus(struct
> > pci_dev *dev, char *reset_type)
> >  		delay);
> >  	if (!pcie_wait_for_link_delay(dev, true, delay)) {
> >  		/* Did not train, no need to wait any further */
> > -		pci_info(dev, "Data Link Layer Link Active not set
> > in 1000 msec\n");
> > +		pci_info(dev, "Data Link Layer Link Active not set
> > in %d msec\n", delay);
> >  		return -ENOTTY;
> >  	}
> >  
> 
> 


      reply	other threads:[~2025-04-14  0:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-12  6:09 Wilfred Mallawa
2025-04-13  5:17 ` Damien Le Moal
2025-04-14  0:18   ` Wilfred Mallawa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294b288226cba1f9bc63956720be9c0b2ac6117.camel@gmail.com \
    --to=wilfred.opensource@gmail.com \
    --cc=alistair.francis@wdc.com \
    --cc=bhelgaas@google.com \
    --cc=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mika.westerberg@linux.intel.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®