mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Chris Ball <cjb@laptop.org>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] mmc: sdhci-of does not build on x86
Date: Fri, 14 Jan 2011 13:29:51 +0100	[thread overview]
Message-ID: <1295008191-1596-1-git-send-email-mmarek@suse.cz> (raw)

After commit c10d1e2, CONFIG_OLPC selects CONFIG_OF, which enables to
select CONFIG_MMC_SDHCI_OF, which does not build on x86:

drivers/mmc/host/sdhci-of-core.c:24:25: fatal error: asm/machdep.h: No
such file or directory

Signed-off-by: Michal Marek <mmarek@suse.cz>
---

I don't know if the driver could possibly work on some OLPC hardware,
but it wasn't used on x86 before, so this patch won't make things any worse.

Michal
---
 drivers/mmc/host/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index afe8c6f..9901656 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -83,7 +83,7 @@ config MMC_RICOH_MMC
 
 config MMC_SDHCI_OF
 	tristate "SDHCI support on OpenFirmware platforms"
-	depends on MMC_SDHCI && OF
+	depends on MMC_SDHCI && OF && !X86
 	help
 	  This selects the OF support for Secure Digital Host Controller
 	  Interfaces.
-- 
1.7.3.4


             reply	other threads:[~2011-01-14 12:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-14 12:29 Michal Marek [this message]
2011-01-14 14:39 ` Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295008191-1596-1-git-send-email-mmarek@suse.cz \
    --to=mmarek@suse.cz \
    --cc=cjb@laptop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®