From: Vasiliy Kulikov <segoon@openwall.com>
To: kernel-janitors@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Ben Gardner <bgardner@wabtec.com>,
Andres Salomon <dilinger@queued.net>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] staging: cs5535_gpio: check put_user() return code
Date: Mon, 17 Jan 2011 13:08:49 +0300 [thread overview]
Message-ID: <1295258929-31350-1-git-send-email-segoon@openwall.com> (raw)
put_user() may fail, if so return -EFAULT.
Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
---
Compile tested only.
drivers/staging/cs5535_gpio/cs5535_gpio.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/cs5535_gpio/cs5535_gpio.c b/drivers/staging/cs5535_gpio/cs5535_gpio.c
index 0cf1e5f..b25f9d1 100644
--- a/drivers/staging/cs5535_gpio/cs5535_gpio.c
+++ b/drivers/staging/cs5535_gpio/cs5535_gpio.c
@@ -146,7 +146,8 @@ static ssize_t cs5535_gpio_read(struct file *file, char __user *buf,
/* add a line-feed if there is room */
if ((i == ARRAY_SIZE(rm)) && (count < len)) {
- put_user('\n', buf + count);
+ if (put_user('\n', buf + count))
+ return -EFAULT;
count++;
}
--
1.7.0.4
reply other threads:[~2011-01-17 10:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295258929-31350-1-git-send-email-segoon@openwall.com \
--to=segoon@openwall.com \
--cc=akpm@linux-foundation.org \
--cc=bgardner@wabtec.com \
--cc=devel@driverdev.osuosl.org \
--cc=dilinger@queued.net \
--cc=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®