From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753245Ab1ARUW3 (ORCPT ); Tue, 18 Jan 2011 15:22:29 -0500 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.124]:62619 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751745Ab1ARUW1 (ORCPT ); Tue, 18 Jan 2011 15:22:27 -0500 X-Authority-Analysis: v=1.1 cv=+c36koQ5Dcj/1qolKHjtkYAGXvrVJRRiKMp+84F5sLg= c=1 sm=0 a=44vUGAvzfu8A:10 a=Q9fys5e9bTEA:10 a=OPBmh+XkhLl+Enan7BmTLg==:17 a=meVymXHHAAAA:8 a=e6tHPeC81y11zkmXj2oA:9 a=LoaeXjGvLh53rZkO-yEA:7 a=Vnllp0A_kzUuQpLxIxAzkujX8KIA:4 a=PUjeQqilurYA:10 a=jeBq3FmKZ4MA:10 a=OPBmh+XkhLl+Enan7BmTLg==:117 X-Cloudmark-Score: 0 X-Originating-IP: 67.242.120.143 Subject: Re: Bug#609371: linux-image-2.6.37-trunk-sparc64: module scsi_mod: Unknown relocation: 36 From: Steven Rostedt To: Mathieu Desnoyers Cc: David Miller , richm@oldelvet.org.uk, 609371@bugs.debian.org, ben@decadent.org.uk, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, fweisbec@gmail.com, mingo@redhat.com In-Reply-To: <20110118201323.GA14930@Krystal> References: <1295273486.16479.15.camel@gandalf.stny.rr.com> <20110117.213448.226787087.davem@davemloft.net> <20110117.220039.71097651.davem@davemloft.net> <20110117.220857.104046847.davem@davemloft.net> <20110118164633.GA12872@Krystal> <1295372019.12215.30.camel@gandalf.stny.rr.com> <1295374595.12215.32.camel@gandalf.stny.rr.com> <1295375178.12215.33.camel@gandalf.stny.rr.com> <20110118201323.GA14930@Krystal> Content-Type: text/plain; charset="ISO-8859-15" Date: Tue, 18 Jan 2011 15:22:24 -0500 Message-ID: <1295382144.12215.123.camel@gandalf.stny.rr.com> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2011-01-18 at 15:13 -0500, Mathieu Desnoyers wrote: > * Steven Rostedt (rostedt@goodmis.org) wrote: > > On Tue, 2011-01-18 at 13:16 -0500, Steven Rostedt wrote: > > > On Tue, 2011-01-18 at 12:33 -0500, Steven Rostedt wrote: > > > > On Tue, 2011-01-18 at 11:46 -0500, Mathieu Desnoyers wrote: > > > > > > > > Also align TRACE_PRINTKS on 8 bytes to make sure the beginning of the section is > > > > > aligned on pointer size. > > > > > > > > If I can make it crash without the alignments and this fixes the issue, > > > > I'll apply both patches. > > > > > > After applying David's patch, I do indeed get a crash. I'll now apply > > > yours and see if it fixes the issue. > > > > Your patch doesn't seem to fix it either. I'll investigate this further. > > I think David's patch missed kernel/trace/trace_export.c > > struct ftrace_event_call __used \ > __attribute__((__aligned__(4))) \ > __attribute__((section("_ftrace_events"))) event_##call = { \ > > and kernel/trace/trace.h: > > #define FTRACE_ENTRY(call, struct_name, id, tstruct, print) \ > extern struct ftrace_event_call \ > __attribute__((__aligned__(4))) event_##call; > > does it help if you remove these ? I doubt it, but I'll try it anyway. -- Steve