From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754247Ab1AUHuJ (ORCPT ); Fri, 21 Jan 2011 02:50:09 -0500 Received: from mail-fx0-f46.google.com ([209.85.161.46]:55974 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753634Ab1AUHuD (ORCPT ); Fri, 21 Jan 2011 02:50:03 -0500 From: Michal Simek To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Michal Simek , Andrea Arcangeli , Linus Torvalds , Andrew Morton , Rik van Riel , Ingo Molnar Subject: [PATCH] mm: System without MMU do not need pte_mkwrite Date: Fri, 21 Jan 2011 08:49:56 +0100 Message-Id: <1295596196-8233-2-git-send-email-monstr@monstr.eu> X-Mailer: git-send-email 1.5.5.1 In-Reply-To: <1295596196-8233-1-git-send-email-monstr@monstr.eu> References: <1295596196-8233-1-git-send-email-monstr@monstr.eu> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch "thp: export maybe_mkwrite" (sha1 14fd403f2146f740942d78af4e0ee59396ad8eab) break systems without MMU. Error log: CC arch/microblaze/mm/init.o In file included from include/linux/mman.h:14, from arch/microblaze/mm/consistent.c:24: include/linux/mm.h: In function 'maybe_mkwrite': include/linux/mm.h:482: error: implicit declaration of function 'pte_mkwrite' include/linux/mm.h:482: error: incompatible types in assignment Signed-off-by: Michal Simek CC: Andrea Arcangeli CC: Linus Torvalds CC: Andrew Morton CC: Rik van Riel CC: Ingo Molnar --- include/linux/mm.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 956a355..f6385fc 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -470,6 +470,7 @@ static inline void set_compound_order(struct page *page, unsigned long order) page[1].lru.prev = (void *)order; } +#ifdef CONFIG_MMU /* * Do pte_mkwrite, but only if the vma says VM_WRITE. We do this when * servicing faults for write access. In the normal case, do always want @@ -482,6 +483,7 @@ static inline pte_t maybe_mkwrite(pte_t pte, struct vm_area_struct *vma) pte = pte_mkwrite(pte); return pte; } +#endif /* * Multiple processes may "see" the same page. E.g. for untouched -- 1.5.5.6