From: Steven Rostedt <rostedt@goodmis.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org, linux-hotplug@vger.kernel.org,
amit.kucheria@linaro.org
Subject: Re: [PATCH V2] tracing, perf : add cpu hotplug trace events
Date: Fri, 21 Jan 2011 12:28:26 -0500 [thread overview]
Message-ID: <1295630906.12215.4244.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <AANLkTinhX6UwQA0HFhuu5=jbq84woVhqtahuzA5hEo2o@mail.gmail.com>
On Fri, 2011-01-21 at 09:43 +0100, Vincent Guittot wrote:
> On 20 January 2011 17:11, Frederic Weisbecker <fweisbec@gmail.com> wrote:
> >
> >> +DEFINE_EVENT(cpu_hotplug, cpu_hotplug_arch_wait_die_start,
> >> +
> >> + TP_PROTO(unsigned int cpuid),
> >> +
> >> + TP_ARGS(cpuid)
> >> +);
> >> +
> >> +DEFINE_EVENT(cpu_hotplug, cpu_hotplug_arch_wait_die_end,
> >> +
> >> + TP_PROTO(unsigned int cpuid),
> >> +
> >> + TP_ARGS(cpuid)
> >> +);
> >
> > What is wait die, compared to die for example?
> >
>
> The arch_wait_die is used to trace the process which waits for the cpu
> to die (__cpu_die) and the arch_die is used to trace when the cpu dies
> (cpu_die)
Shouldn't that be "cpu_hotplug_arch_task_wait_die" then? If it is a task
that is waiting?
-- Steve
>
> > We need those tracepoints to be applied to get that reviewable in practice.
> >
>
> Ok, I'm going to send a proposal
>
> > Thanks.
> >
prev parent reply other threads:[~2011-01-21 17:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 8:25 Vincent Guittot
2011-01-20 16:11 ` Frederic Weisbecker
2011-01-21 8:43 ` Vincent Guittot
2011-01-21 16:44 ` Frederic Weisbecker
2011-01-21 17:41 ` Vincent Guittot
2011-01-22 2:42 ` Frederic Weisbecker
2011-01-24 9:02 ` Vincent Guittot
2011-01-21 17:28 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295630906.12215.4244.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=amit.kucheria@linaro.org \
--cc=fweisbec@gmail.com \
--cc=linux-hotplug@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®