From: Steven Rostedt <rostedt@goodmis.org>
To: Daniel Walker <dwalker@codeaurora.org>
Cc: "Ted Ts'o" <tytso@mit.edu>, Pekka Enberg <penberg@kernel.org>,
Dima Zavin <dmitriyz@google.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Joe Perches <joe@perches.com>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, davidb@codeaurora.org
Subject: Re: [PATCH 0/7] Nexus One Support
Date: Fri, 21 Jan 2011 21:32:36 -0500 [thread overview]
Message-ID: <1295663556.12215.4812.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1295662437.22882.19.camel@m0nster>
On Fri, 2011-01-21 at 18:13 -0800, Daniel Walker wrote:
> On Fri, 2011-01-21 at 20:58 -0500, Steven Rostedt wrote:
> > On Fri, Jan 21, 2011 at 04:03:13PM -0800, Daniel Walker wrote:
> > >
> > > right, but it wasn't a cherrypick which was explain in the thread. So
> > > there's no wrongs here ..
> >
> > I'm sorry Daniel, but you are absolutely wrong!
>
> This thread is getting way out of hand .. I think you really don't
> understand what has happened here.. That's fine tho, if you don't like
> what I've done then NAK, I'm not going to argue with any you.
Sorry for coming off a bit strong, but I've known you for a while, and
that is usually the best way to get you to understand.
I don't want to argue, but instead teach you that there is a process of
getting code into the kernel, and a etiquette (not to mention legal) way
of doing things.
If you take code from someone else, look at it, and make it work, or do
whatever changes to it. You must keep some form of authorship with the
original author. If you rewrote it completely so that it doesn't look
anything like what the original code was, then sure, its yours. But then
the copyright would belong to you.
But you stated that the copyright was not yours but googles. You are not
employed by google are you? The major problem I have with these patches
is that you got code from somewhere else but had no Signed-off-bys from
anyone. This is where legal comes in.
How do you know this code was attained legally? Can you take sole
responsibility that the code was not stolen from non GPL code? The only
tag line in a change log that matters is that Signed-off-by. Its the one
with (sorta) legal powers. This is saying that you verify that this code
was given to you through legal means. Either that you wrote the code
yourself and are not under any contract to keep it from becoming GPL, or
you took it from someone that gave you their own Signed-off-by that you
can trust.
The biggest problem with your patch set is that it is missing the
necessary Signed-off-bys. Also, the only Signed-off-by that you can
write is your own. Someone can give you their Signed-off-by and you can
add it. There's been patches that I would not accept until the author
gave me (usually publicly) their Signed-off-by.
If you had those, I would not have written the email that I wrote.
-- Steve
next prev parent reply other threads:[~2011-01-22 2:32 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 20:32 Daniel Walker
2011-01-20 20:32 ` [PATCH 1/7] msm: qsd8x50: add uart platform data Daniel Walker
2011-01-20 20:32 ` [PATCH 2/7] [ARM] msm: qsd8k memory base is at 0x20000000 Daniel Walker
2011-01-20 20:32 ` [PATCH 3/7] msm: qsd8x50: add acpuclock code Daniel Walker
2011-01-20 20:32 ` [PATCH 4/7] msm: mahimahi: add mahimahi board file Daniel Walker
2011-01-20 20:32 ` [PATCH 5/7] msm: mahimahi: add in mmc support code Daniel Walker
2011-01-20 20:32 ` [PATCH 6/7] msm: mahimahi: add gpio pin muxing code Daniel Walker
2011-01-20 20:32 ` [PATCH 7/7] msm: mahimahi: initialize mmc at start up Daniel Walker
2011-01-21 0:42 ` [PATCH 0/7] Nexus One Support Dima Zavin
2011-01-21 0:55 ` Daniel Walker
2011-01-21 1:41 ` Joe Perches
2011-01-21 1:58 ` Daniel Walker
2011-01-21 2:13 ` Dima Zavin
2011-01-21 15:47 ` Daniel Walker
2011-01-21 2:25 ` Joe Perches
2011-01-21 3:41 ` Theodore Tso
2011-01-21 15:46 ` Daniel Walker
2011-01-21 17:48 ` Jesse Barnes
2011-01-21 17:56 ` Daniel Walker
2011-01-21 17:59 ` Christoph Hellwig
2011-01-21 17:56 ` Jesse Barnes
2011-01-21 18:00 ` Daniel Walker
2011-01-21 18:04 ` Jesse Barnes
2011-01-21 18:18 ` Daniel Walker
2011-01-21 18:27 ` Jesse Barnes
2011-01-21 18:35 ` Daniel Walker
2011-01-21 20:44 ` Dima Zavin
2011-01-21 20:49 ` Daniel Walker
2011-01-21 21:01 ` Jesse Barnes
2011-01-21 21:26 ` Daniel Walker
2011-01-21 21:42 ` Dima Zavin
2011-01-22 13:58 ` David Woodhouse
2011-01-21 21:02 ` Joe Perches
2011-01-21 21:24 ` Daniel Walker
2011-01-22 11:18 ` Pekka Enberg
2011-01-22 12:20 ` Russell King - ARM Linux
2011-01-22 18:06 ` Dima Zavin
2011-01-22 18:49 ` Russell King - ARM Linux
2011-01-22 20:50 ` Christoph Hellwig
2011-01-22 19:22 ` Brian Swetland
2011-01-22 19:49 ` Nicolas Pitre
2011-01-22 19:59 ` Brian Swetland
2011-01-22 20:53 ` Christoph Hellwig
2011-01-22 21:04 ` Russell King - ARM Linux
2011-01-22 21:57 ` Alan Cox
2011-01-23 2:38 ` David Woodhouse
2011-01-22 20:41 ` Christoph Hellwig
2011-01-21 21:05 ` Pekka Enberg
2011-01-21 21:17 ` Joe Perches
2011-01-21 23:49 ` Ted Ts'o
2011-01-22 0:03 ` Daniel Walker
2011-01-22 1:58 ` Steven Rostedt
2011-01-22 2:13 ` Daniel Walker
2011-01-22 2:32 ` Steven Rostedt [this message]
2011-01-22 2:31 ` Ted Ts'o
2011-01-22 8:19 ` Pekka Enberg
2011-01-22 10:35 ` Dima Zavin
2011-01-22 10:45 ` Anca Emanuel
2011-01-22 11:03 ` Pekka Enberg
2011-01-22 11:15 ` Pekka Enberg
2011-01-22 17:28 ` Thomas Gleixner
2011-01-22 18:07 ` Denis 'GNUtoo' Carikli
2011-01-22 18:15 ` Dima Zavin
2011-01-22 20:55 ` Christoph Hellwig
2011-01-22 21:56 ` Pekka Enberg
2011-01-22 21:58 ` Christoph Hellwig
2011-01-22 22:13 ` Pekka Enberg
2011-02-04 13:36 ` Pavel Machek
2011-02-07 17:36 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295663556.12215.4812.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=davidb@codeaurora.org \
--cc=dmitriyz@google.com \
--cc=dwalker@codeaurora.org \
--cc=jbarnes@virtuousgeek.org \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®