From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 883F31078A; Tue, 26 Dec 2023 23:54:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="mNlcdX7Y" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=HVJev5bn/SXmUllhi1fZYGckmmp1VVLDmEqAwl2Z208=; b=mNlcdX7YAzTroaH2aOGFi3ncxR 2pNVzBaD/QlHN+u5vcyz9kJsWseAFVvJP5qwfpYJojtLD66OSY2Hdxbv705YjapFqRt9x649dxUap xmXLFccJ/U2UE3uG62d1IC6SlQSIu1tJuY9x19T9yNKI970Yt1H0l4mu4krvCTfg+Gr1Tz08eFp6t ueFWeDf0saiU6NwIdKiYcLLBTGa6uGwZUvOLtTmBUJ0pxig+BimyaCGwZtR5W20M59Zkh6V4MUwsv cr5PBKj3rAuFqFBJg7EQUi1SpzJFHMo/eGV0ZbkePXXw4/quDWjgFOd2XlTiIuqIk6lw3+2eL1nss MQfvPDeg==; Received: from [50.53.46.231] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rIHFC-00DgKc-0t; Tue, 26 Dec 2023 23:53:54 +0000 Message-ID: <12958640-e6c0-43d3-a710-48ba7873c8f5@infradead.org> Date: Tue, 26 Dec 2023 15:53:53 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] xprtrdma: removed unnecessary headers from verbs.c Content-Language: en-US To: Tanzir Hasan Cc: Chuck Lever , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Nick Desaulniers , Al Viro References: <20231226-verbs-v1-1-3a2cecf11afd@google.com> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Tanzir, On 12/26/23 15:35, Tanzir Hasan wrote: > On Tue, Dec 26, 2023 at 3:20 PM Randy Dunlap wrote: >> >> Hi, >> >> On 12/26/23 13:23, Tanzir Hasan wrote: >>> asm-generic/barrier.h and asm/bitops.h are already brought into the >>> header and the file can still be built with their removal. >> >> Brought into which header? > Hi Randy, > > Sorry for the poor explanation. I see that I left out the specific header. > The inclusion of linux/sunrpc/svc_rdma.h brings in linux/sunrpc/rpc_rdma.h > This brings in linux/bitops.h which is preferred over asm/bitops.h > >> Does this conflict with Rule #1 in Documentation/process/submit-checklist.rst ? > > Yes, this conflicts with Rule #1. A better version of this patch would be to add > linux/bitops.h to this file directly. The main reason this patch > exists is to clear > out the asm-generic file since those are not preferred. I can do this by either > including just linux/bitops.h or including both linux/bitops.h and > asm/barrier.h. > Would the second approach conform better with Rule #1? Yes, it would IMO. Where can I find your current working list of what/how to #include? Thanks. -- #Randy