mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Radu Voicilas <rvoicilas@gmail.com>
To: eparis@redhat.com
Cc: linux-kernel@vger.kernel.org, Radu Voicilas <rvoicilas@gmail.com>
Subject: [PATCH] fsnotify.h: Dropped redundant code.
Date: Mon, 24 Jan 2011 19:45:26 +0200	[thread overview]
Message-ID: <1295891126-31540-1-git-send-email-rvoicilas@gmail.com> (raw)

The code that checks to see whether the provided dentry object is valid
or not is redundant with the one that's in fs/notify/fsnotify.c in
the __fsnotify_parent function:

    if (!dentry)
        dentry = path->dentry;

Signed-off-by: Radu Voicilas <rvoicilas@gmail.com>
---
 include/linux/fsnotify.h |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/include/linux/fsnotify.h b/include/linux/fsnotify.h
index 2a53f10..9e67a41 100644
--- a/include/linux/fsnotify.h
+++ b/include/linux/fsnotify.h
@@ -27,9 +27,6 @@ static inline void fsnotify_d_instantiate(struct dentry *dentry,
 /* Notify this dentry's parent about a child's events. */
 static inline int fsnotify_parent(struct path *path, struct dentry *dentry, __u32 mask)
 {
-	if (!dentry)
-		dentry = path->dentry;
-
 	return __fsnotify_parent(path, dentry, mask);
 }
 
-- 
1.7.0.4


                 reply	other threads:[~2011-01-24 17:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295891126-31540-1-git-send-email-rvoicilas@gmail.com \
    --to=rvoicilas@gmail.com \
    --cc=eparis@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®