From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: James Bottomley <James.Bottomley@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
Mike Christie <michaelc@cs.wisc.edu>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-scsi <linux-scsi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL for 38-rc3] target updates for v4.0.0-rc7
Date: Mon, 24 Jan 2011 18:48:06 -0800 [thread overview]
Message-ID: <1295923686.24778.200.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <1295922411.15425.126.camel@mulgrave.site>
On Mon, 2011-01-24 at 20:26 -0600, James Bottomley wrote:
> On Mon, 2011-01-24 at 17:55 -0800, Nicholas A. Bellinger wrote:
> > On Mon, 2011-01-24 at 19:38 -0600, James Bottomley wrote:
> [...]
> > > Over the list, please, not in a git tree. What I need is for others to
> > > review them ... and appearing on the list best encourages that.
> > >
> >
> > Yes, but to clarify one item. All of these patches in for-38-rc3 and
> > for-jejb branches have already been sent out to linux-scsi incrementally
> > when they where committed into LIO upstream code. Are you asking that
> > the entire patch series be re-sent to linux-scsi against .38-rc2..?
>
> What I want is for you to tidy them up, make changelogs intelligible,
> sanity check them (like merge patches for people who submit one patch
> per file), run checkpatch, make sure series compiles and integration
> test them before rolling them up in a batch and sending them on (at an
> interval of about one or two batches per merge window) ... in essence,
> what a maintainer does.
>
Yes, this is more-or-less exactly I have been doing for the .38 round.
This particular series could stand to have a few more minor commit's
squashed together, and a quick run through checkpatch as well. But
other that these small items, the commits have been made tidy, with
intelligible changelogs + proper authorship with target v4.0.0-rc7
running in .38-rc2 x86_64 VM, and the bugfixes ready to be included for
mainline.
Squashing will probably save only 2-3 commits in this particular series,
but I will get these minor items condensed and produce a followup GIT
PULL v2 request from scsi-post-merge-2.6.git/for-38-rc3 against
linus .38-rc2.
Again just to verify, these will be sent out in their entirety to
linux-scsi.
--nab
prev parent reply other threads:[~2011-01-25 2:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 0:14 Nicholas A. Bellinger
2011-01-25 0:36 ` James Bottomley
2011-01-25 1:27 ` Nicholas A. Bellinger
2011-01-25 1:38 ` James Bottomley
2011-01-25 1:55 ` Nicholas A. Bellinger
2011-01-25 2:26 ` James Bottomley
2011-01-25 2:48 ` Nicholas A. Bellinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295923686.24778.200.camel@haakon2.linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=James.Bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®