From: Marek Belisko <marek.belisko@open-nandra.com>
To: gregkh@suse.de
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Marek Belisko <marek.belisko@open-nandra.com>
Subject: [PATCH v2 06/11] staging: ft1000: Fix coding style in get_request_type() function.
Date: Tue, 25 Jan 2011 14:05:01 +0100 [thread overview]
Message-ID: <1295960706-15667-7-git-send-email-marek.belisko@open-nandra.com> (raw)
In-Reply-To: <1295960706-15667-1-git-send-email-marek.belisko@open-nandra.com>
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
---
.../staging/ft1000/ft1000-usb/ft1000_download.c | 38 +++++++++-----------
1 files changed, 17 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c b/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
index 1e442fc..f87b927 100644
--- a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
+++ b/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
@@ -340,30 +340,26 @@ static void put_handshake_usb(struct ft1000_device *ft1000dev,u16 handshake_valu
//---------------------------------------------------------------------------
static u16 get_request_type(struct ft1000_device *ft1000dev)
{
- u16 request_type;
- u32 status;
- u16 tempword;
- u32 tempx;
+ u16 request_type;
+ u32 status;
+ u16 tempword;
+ u32 tempx;
struct ft1000_info *pft1000info = netdev_priv(ft1000dev->net);
- if ( pft1000info->bootmode == 1)
- {
- status = fix_ft1000_read_dpram32 (ft1000dev, DWNLD_MAG1_TYPE_LOC, (u8 *)&tempx);
- tempx = ntohl(tempx);
- }
- else
- {
- tempx = 0;
-
- status = ft1000_read_dpram16 (ft1000dev, DWNLD_MAG1_TYPE_LOC, (u8 *)&tempword, 1);
- tempx |= (tempword << 16);
- tempx = ntohl(tempx);
- }
- request_type = (u16)tempx;
-
- //DEBUG("get_request_type: request_type is %x\n", request_type);
- return request_type;
+ if (pft1000info->bootmode == 1) {
+ status = fix_ft1000_read_dpram32(ft1000dev,
+ DWNLD_MAG1_TYPE_LOC, (u8 *)&tempx);
+ tempx = ntohl(tempx);
+ } else {
+ tempx = 0;
+ status = ft1000_read_dpram16(ft1000dev,
+ DWNLD_MAG1_TYPE_LOC, (u8 *)&tempword, 1);
+ tempx |= (tempword << 16);
+ tempx = ntohl(tempx);
+ }
+ request_type = (u16)tempx;
+ return request_type;
}
static u16 get_request_type_usb(struct ft1000_device *ft1000dev)
--
1.7.1
next prev parent reply other threads:[~2011-01-25 13:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 13:04 [PATCH v2 00/11] staging: ft1000: Various coding style cleanups Marek Belisko
2011-01-25 13:04 ` [PATCH v2 01/11] staging: ft1000: Remove dead code Marek Belisko
2011-01-25 13:04 ` [PATCH v2 02/11] staging: ft1000: Fix coding style in check_usb_db() function Marek Belisko
2011-01-25 13:04 ` [PATCH v2 03/11] staging: ft1000: Fix coding style in put_handshake() function Marek Belisko
2011-01-25 13:04 ` [PATCH v2 04/11] staging: ft1000: Fix coding style in get_handshake_usb() function Marek Belisko
2011-01-25 13:05 ` [PATCH v2 05/11] staging: ft1000: Fix coding style in put_handshake_usb() function Marek Belisko
2011-01-25 13:05 ` Marek Belisko [this message]
2011-01-25 13:05 ` [PATCH v2 07/11] staging: ft1000: Fix coding style in get_request_type_usb() function Marek Belisko
2011-01-25 13:05 ` [PATCH v2 08/11] staging: ft1000: Fix coding style in get_request_value() function Marek Belisko
2011-01-25 13:05 ` [PATCH v2 09/11] staging: ft1000: Fix coding style in put_request_value() function Marek Belisko
2011-01-25 15:23 ` Alexey Dobriyan
2011-01-25 13:05 ` [PATCH v2 10/11] staging: ft1000: Fix coding style in hdr_checksum() function Marek Belisko
2011-01-25 13:05 ` [PATCH v2 11/11] staging: ft1000: Fix coding style in get_handshake() function Marek Belisko
2011-01-25 13:32 ` [PATCH v2 00/11] staging: ft1000: Various coding style cleanups Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295960706-15667-7-git-send-email-marek.belisko@open-nandra.com \
--to=marek.belisko@open-nandra.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®