mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Stefan Bader <stefan.bader@canonical.com>
Cc: Jeremy Fitzhardinge <Jeremy.Fitzhardinge@citrix.com>,
	"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen: p2m: correctly initialize partial p2m leave
Date: Tue, 25 Jan 2011 16:54:32 +0000	[thread overview]
Message-ID: <1295974472.14780.6579.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <4D3848DF.9000906@canonical.com>

Please always include an inline copy of a patch for easier
review-by-reply, even if you also include an attachment because your
mailer mangles patches.

Anyway, I suspect the following comment is obsoleted by Jeremy's "just
do it in place" suggestion but:

On Thu, 2011-01-20 at 14:38 +0000, Stefan Bader wrote:
> [...]
> +                       unsigned long **p2m = extend_brk(PAGE_SIZE, PAGE_SIZE);

I think this would need to be matched by a corresponding RESERVE_BRK of some sort.

Ian.



  parent reply	other threads:[~2011-01-25 16:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-20 14:38 Stefan Bader
2011-01-20 15:10 ` Konrad Rzeszutek Wilk
2011-01-24  4:49   ` [Xen-devel] " Jeremy Fitzhardinge
2011-01-24  9:06     ` Stefan Bader
2011-01-21 14:26 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-01-21 14:42   ` Stefan Bader
2011-01-25 16:54 ` Ian Campbell [this message]
2011-01-25 18:48   ` Stefan Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295974472.14780.6579.camel@zakaz.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=Jeremy.Fitzhardinge@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefan.bader@canonical.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®