From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Alexander Koskovich <AKoskovich@pm.me>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 2/2] usb: typec: qcom: Add support for shared USBIN VBUS detection
Date: Wed, 11 Mar 2026 14:39:20 +0000 [thread overview]
Message-ID: <1295e256-ad5c-4d20-b928-792b251fa9fe@linaro.org> (raw)
In-Reply-To: <5304144a-0907-4b7e-8c65-d0d37e74e9f8@oss.qualcomm.com>
On 11/03/2026 13:01, Konrad Dybcio wrote:
>> + pmic_typec_port->vbus_detect_gpio = devm_gpiod_get_optional(dev, "vbus-detect",
>> + GPIOD_IN);
> I thought the intent here was to have 2 GPIOs, one per port - could
> you please shed some light on this?
You should have two instances of the driver. One for each port so one
GPIO detect in-lieu of VBUS per port.
So for this board we would expect to see
- pmic@2::pm8150b_typec: typec@1500
- pmic@3::pm8150b_typec: typec@1500
and a VBUS GPIO associated with each type-c connector.
---
bod
next prev parent reply other threads:[~2026-03-11 14:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 23:20 [PATCH RFC 0/2] usb: typec: qcom: Add shared USBIN VBUS detection via GPIO Alexander Koskovich
2026-03-08 23:20 ` [PATCH RFC 1/2] dt-bindings: usb: qcom,pmic-typec: Document vbus-detect-gpios property Alexander Koskovich
2026-03-11 23:02 ` Bryan O'Donoghue
2026-03-16 10:15 ` Konrad Dybcio
2026-03-12 2:34 ` Dmitry Baryshkov
2026-03-12 2:59 ` Alexander Koskovich
2026-03-08 23:20 ` [PATCH RFC 2/2] usb: typec: qcom: Add support for shared USBIN VBUS detection Alexander Koskovich
2026-03-11 13:01 ` Konrad Dybcio
2026-03-11 14:39 ` Bryan O'Donoghue [this message]
2026-03-11 16:24 ` Alexander Koskovich
2026-03-11 23:05 ` Bryan O'Donoghue
2026-03-12 6:18 ` Alexander Koskovich
2026-03-11 14:50 ` [PATCH RFC 0/2] usb: typec: qcom: Add shared USBIN VBUS detection via GPIO Bryan O'Donoghue
2026-03-11 17:37 ` Alexander Koskovich
2026-03-11 23:00 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295e256-ad5c-4d20-b928-792b251fa9fe@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=AKoskovich@pm.me \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®