mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shane Wang <shane.wang@intel.com>
To: linux-kernel@vger.kernel.org, tboot-devel@lists.sourceforge.net
Cc: jonmccune@cmu.edu, joseph.cihula@intel.com, shane.wang@intel.com
Subject: [PATCH RESEND] intel_txt: Add more explicit dependencies for CONFIG_INTEL_TXT
Date: Thu, 27 Jan 2011 07:43:27 +0800	[thread overview]
Message-ID: <1296085407-15880-1-git-send-email-shane.wang@intel.com> (raw)

This patch is to follow the recommended way in kconfig-language.txt to use HAVE_INTEL_TXT, so to add more explicit dependencies for CONFIG_INTEL_TXT.

Signed-off-by: Jonathan McCune <jonmccune@cmu.edu>
Signed-off-by: Shane Wang <shane.wang@intel.com>

---
 Documentation/intel_txt.txt |    4 +++-
 arch/x86/Kconfig            |    5 +----
 security/Kconfig            |    5 ++++-
 3 files changed, 8 insertions(+), 6 deletions(-)

diff -r 95e0d1104426 Documentation/intel_txt.txt
--- a/Documentation/intel_txt.txt	Thu Jan 27 07:04:38 2011 +0800
+++ b/Documentation/intel_txt.txt	Thu Jan 27 07:37:23 2011 +0800
@@ -196,7 +196,9 @@
 depends on the generic x86 support (to allow maximum flexibility in
 kernel build options), since the tboot code will detect whether the
 platform actually supports Intel TXT and thus whether any of the
-kernel code is executed.
+kernel code is executed. The kernel option for enabling Intel TXT
+support will only appear if its dependencies are also enabled.
+These are CONFIG_DMAR and CONFIG_ACPI.
 
 The Q35_SINIT_17.BIN file is what Intel TXT refers to as an
 Authenticated Code Module.  It is specific to the chipset in the
diff -r 95e0d1104426 arch/x86/Kconfig
--- a/arch/x86/Kconfig	Thu Jan 27 07:04:38 2011 +0800
+++ b/arch/x86/Kconfig	Thu Jan 27 07:37:23 2011 +0800
@@ -65,6 +65,7 @@
 	select HAVE_SPARSE_IRQ
 	select GENERIC_IRQ_PROBE
 	select GENERIC_PENDING_IRQ if SMP
+	select HAVE_INTEL_TXT
 
 config INSTRUCTION_DECODER
 	def_bool (KPROBES || PERF_EVENTS)
@@ -199,10 +200,6 @@
 config ARCH_SUPPORTS_DEBUG_PAGEALLOC
 	def_bool y
 
-config HAVE_INTEL_TXT
-	def_bool y
-	depends on EXPERIMENTAL && DMAR && ACPI
-
 config USE_GENERIC_SMP_HELPERS
 	def_bool y
 	depends on SMP
diff -r 95e0d1104426 security/Kconfig
--- a/security/Kconfig	Thu Jan 27 07:04:38 2011 +0800
+++ b/security/Kconfig	Thu Jan 27 07:37:23 2011 +0800
@@ -103,9 +103,12 @@
 	  implement pathname based access controls.
 	  If you are unsure how to answer this question, answer N.
 
+config HAVE_INTEL_TXT
+	bool
+
 config INTEL_TXT
 	bool "Enable Intel(R) Trusted Execution Technology (Intel(R) TXT)"
-	depends on HAVE_INTEL_TXT
+	depends on HAVE_INTEL_TXT && EXPERIMENTAL && DMAR && ACPI
 	help
 	  This option enables support for booting the kernel with the
 	  Trusted Boot (tboot) module. This will utilize

                 reply	other threads:[~2011-01-25  8:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296085407-15880-1-git-send-email-shane.wang@intel.com \
    --to=shane.wang@intel.com \
    --cc=jonmccune@cmu.edu \
    --cc=joseph.cihula@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tboot-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®