From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754816Ab1A3MjM (ORCPT ); Sun, 30 Jan 2011 07:39:12 -0500 Received: from mail-in-01.arcor-online.net ([151.189.21.41]:60180 "EHLO mail-in-01.arcor-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754253Ab1A3Mij (ORCPT ); Sun, 30 Jan 2011 07:38:39 -0500 X-DKIM: Sendmail DKIM Filter v2.8.2 mail-in-15.arcor-online.net 253001AB5F8 Subject: [PATCH 8/8] HID: roccat: Fixed bug that prevented roccat chardev from removing devices From: Stefan Achatz Reply-To: erazor_de@users.sourceforge.net To: Randy Dunlap , Jiri Kosina , Mauro Carvalho Chehab , Stefan Achatz , Andrew Morton , Thomas Weber , Greg Kroah-Hartman , linux-doc@vger.kernel.org, Hans Verkuil , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Date: Sun, 30 Jan 2011 13:38:30 +0100 Message-ID: <1296391110.2283.187.camel@neuromancer> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 (2.30.3-1.fc13) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org pointer to device was cleared too early. This is fixed now. Signed-off-by: Stefan Achatz --- drivers/hid/hid-roccat.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/hid/hid-roccat.c b/drivers/hid/hid-roccat.c index 0fa23de..bbe294c 100644 --- a/drivers/hid/hid-roccat.c +++ b/drivers/hid/hid-roccat.c @@ -356,13 +356,16 @@ void roccat_disconnect(int minor) mutex_lock(&devices_lock); device = devices[minor]; - devices[minor] = NULL; mutex_unlock(&devices_lock); device->exist = 0; /* TODO exist maybe not needed */ device_destroy(device->dev->class, MKDEV(roccat_major, minor)); + mutex_lock(&devices_lock); + devices[minor] = NULL; + mutex_unlock(&devices_lock); + if (device->open) { hid_hw_close(device->hid); wake_up_interruptible(&device->wait); -- 1.7.3.4